From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC1CF42945; Fri, 14 Apr 2023 18:45:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6FAF42D0E; Fri, 14 Apr 2023 18:45:42 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id F0C3B42B8E for ; Fri, 14 Apr 2023 18:45:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niVw0SDCIyU8yobp3B0jebHvjro+/q3VucRe8O73moulGAZbca7vY7XbY4wuquSyFrN5LbvXow7idhDIyA9tsiK5zVSAIZX1R/q40SoruYyQUYRY7kDKRVd2Uxva3Y7+GS+BBX0/quj5t5kVz9KP5Le8nztiREmyRVVoQjHyPWPgLwaB0OLvgw85srQR3V4svy655TP1Pq/N5Vw5CZlfI8h7MdAyYvCRSDKInUM7sFNgQUbxI7tPAKG8EUHAtWZIRsoXRyAboLZs3YyUuyQETSdesqkMCRlwnJ99eH2TmfiWUiQKksHGc8aVO4plVlAo3G0flxBVJQLSxpDQV6sUEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G9G+tcD9RVVoxp/QMaS/VrBFYKgUkmlBqV4s5zdb0+s=; b=arvKIsdv3W+I+zWB1kz52lmX/ZVAviyuSNZ9gTTAjld/IBcp8/rfkbC0SivQdAkWNHc11DeUk5XJpLWEzbGXTedbgS+CyllX/pCDpBcJk9aapeQjoddP9PbbhWuaumxlmklkMv0JTuHK+orJWitF12p8lLvbxgFfa+XNX4YdcxbqSW/sZIq/JqInV0VAoA5w9F5tynuQPH+qH7U3bscWoqdbybzS7bywHEDgzxa2SPyHITXNkpWKXEovgaBylJjQD58TcbLyfwit+ptjzugLnKUFAqnKrphEo2Bl9l5fqPV25E8QVJ5GcYY/n1x6N0RquJ3es4wQLKJvM8XkDKOzhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G9G+tcD9RVVoxp/QMaS/VrBFYKgUkmlBqV4s5zdb0+s=; b=HAPprqeEMu/E4GY+kFvT6JcwceYLqN8PpBF6VjWaga/4NTthjX99VaoMPeQBOd2uQgns4vzAXCeLd7/G5ltaK+wsmT3nhHC6HUQ/8aduH7uVeTI7aRpAr/lxmm4e07RCvm/nSLV7XXdmDCL3pdI9bdLIWFs0WbdgOSs8tMEm+hY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8228.namprd12.prod.outlook.com (2603:10b6:208:402::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.43; Fri, 14 Apr 2023 16:45:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7%7]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 16:45:39 +0000 Message-ID: <3fab5f20-21db-6712-aa40-0b8161970273@amd.com> Date: Fri, 14 Apr 2023 17:45:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Nipun Gupta , dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Cc: harpreet.anand@amd.com, nikhil.agarwal@amd.com References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230413132704.17586-1-nipun.gupta@amd.com> <20230413132704.17586-6-nipun.gupta@amd.com> From: Ferruh Yigit Subject: Re: [PATCH v2 5/6] bus: enable cdx bus In-Reply-To: <20230413132704.17586-6-nipun.gupta@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8228:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f6adcb9-5482-42c6-97a0-08db3d07ad9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wgl5o1xItHhlmsavVzfFSUoszLK8rVfl3h0sWA2Wq8/2H3WE5a0oZGe1tzpWKSKUxQvRzzeY9po8pSV8C6R4ev0z35jmXqVl3M9xTbnFy1CGB7SCE6MFNDfdxBuHHB/9jVMyxkNOh0Qkbj3PkeXXYPl52Uh7UVxqUgIF4Po0BjVzS0anRpMSb2ojW62VYlEvQBG/qffzWEvA9MZSWDYcUO61fIWvs0oSH9yX9bwc+PzxFkkLe0HIquPI831bI8thj232hCEuu9gMHUlRUkHYW5/Ml0D+43R66S5ayxg0KAqvklWPgyrXbDx/EKOpxfY23qYEd+hQysxRCoq2pN04bgK6VflwDI30Dev+wIv0cH13rnZf+1Dx5DWWdi16U6/VYEk8yi4T0yt2lgyCEQOD8nmyWNffWSLvStd4FdenaDPrPEeR2vnh6tIHDvPElUyKk44bWliYhYE3N5unzciHWUQmbYK1ijKTlCg90ytLNLBkNw1PuCvk4WNJDrNjX2IsAr0uQgfqFPoscTV5FGIri3MviPY5ufxWsVYbXfEZP9+48J63TVs5YtPV3ODI4I6+tAW2jzwfGJGtZr+3CAk9wigIPEqJP4lfjos4br2xSRG/+CAoz8V+co1BgEoqS4MIKo2ffXmfwrWJPtskAXQBOg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199021)(478600001)(8936002)(5660300002)(38100700002)(66476007)(66556008)(8676002)(66946007)(41300700001)(4326008)(316002)(31686004)(36756003)(6512007)(53546011)(6506007)(26005)(86362001)(2616005)(186003)(31696002)(44832011)(6666004)(2906002)(4744005)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHJVRkU3T2p1bnZtTlMzRU9KWGRDYmZDR2dqUG1jTzRDZERiVFdVdElmYXZI?= =?utf-8?B?YjEvc3doekdNaTBYMUdDR2NNSVBTbVhRalAvWlZVTEg1ajJYbGxvZmVIZjAw?= =?utf-8?B?cktqZDU4L2ZzZ0lkS216L0FRVGExOXkwUFUvYUsvY0JQVlR1QXZMSnJYLyt6?= =?utf-8?B?MDFiY0NaMXFTeHVWTGRwUEVhN1VjMjNJRDFsRVNiWlIxaG1vcFRIc2RLcVNs?= =?utf-8?B?RnJHeUFLSExIUm83L3JRMm03MkM4bTY3U3FkS0hxdG5GSUcwNVRmOXJpUS9N?= =?utf-8?B?R24rYmRKZmtuUEVSRWZ1UXBacy92cHVCL1NGb2phVEljdm1HTk9OTCtXdzNw?= =?utf-8?B?VitpTHJnVDgybmM3OGRpS1YyZkRaUDYyTUlRQnBqeWVBTG5kNWVYZnFxRnEv?= =?utf-8?B?RitLYytTUmNyU0RZR1VFaWFTR0lYK3BVZlNQVy9yYXhrWC9YQzlISWdJek5s?= =?utf-8?B?S1pOdEFvTlR6NnBIcEVRTncwbVNvUE5vQ0lZbS9mOEdTbllBQ2RyREV6WU5X?= =?utf-8?B?eWpLRkZhOHMzWHpGNUQvRnNLajdScklybmo3QmE1M3dYRG9RS0piWlJ3eXh0?= =?utf-8?B?UmVNRGRCNkJ3NVJDM2FObUc4Ukl4bUt0QW9pMG1jem1xbzVKNDRjb3NKTHY3?= =?utf-8?B?bmlxTitXa1ZTb3o3TWx5c3JIOEFWZmt1bnUwUlVJYzBua2VnZEt4MWtpLzg4?= =?utf-8?B?cUFHZ2VsVFltMk5McWdXRjE5cUFRYUM4ZDlac0FnbFZlek1sb1ZZVGZhZGFP?= =?utf-8?B?L3ZwYVpPQkY0SHZ6MGxvMzFvbzhVVE9MV0lnYk41eTFKWXJqR3BCajR1TzJE?= =?utf-8?B?bWVnV3RKMFZIUFdIaTFsamljMXFSMXdRcVB0TmtIRXBqQTdIZEY5WmllZUI5?= =?utf-8?B?bVI2U041U3lGRmd3MGhaRC9aczRDYkNUbmw4eEdTUVRHTkd4dGN4c3h4TUxv?= =?utf-8?B?SnpLMmNyTDlaYjNITitNK0lrN1hTYVJ4QzBRamhaUWdTeUFNN0RKSlkweThR?= =?utf-8?B?ZXozR0lzbXFXMHVWMUd0d08wWFZpeDVmTDFLMGNGbVVwQS9VN29mWWZNakZK?= =?utf-8?B?S0JPaDQ1UFZsWDl0aFlPQlVUWVBTVnRmZTBjRi9tZW0vcVh1RjV5WFprM0ZW?= =?utf-8?B?TU5Hc0R0ek03d1NGUmRpWVdPTWlFKzE1NHpuSFlaYkd1WlI5U0MxVkM2c21B?= =?utf-8?B?K1F6anFxWmNLTGkwamxkTGVkTW1MNFlIb2JFd3A3VWRTdGFmMlo2NytkNVFx?= =?utf-8?B?dzBFUXFoRGdUY2dxRjJCRnVhTWkxa3BxalJmbWQxdDRwTkwzV0ZwcjFpWjFo?= =?utf-8?B?enUzWUFXMy91ZGsxQzVVOVhlK2l1RlZkeDNTdFVLT1paN1BaQk9EeGJGWita?= =?utf-8?B?dnJ4V0grUXZUbmtHZ01CWC95OFc2ajZUZk9KQlU0LzRRbDh6QWNDaE0zRGJv?= =?utf-8?B?N0tSVldYY1VtK0RyRGs5ZjZReUtZenhia2VjVmd0MWswVjJ0MG4xYnRZN0J0?= =?utf-8?B?aWd3RVh2S3RiYi9UOFBxeUVSQVo5VFlHNElyK0ZGdDBCWm1ZZEVHSVYycUto?= =?utf-8?B?YTVqOHd2YWNCVDJEWmxyLzhQNEVreGs1L081OWhIeGNCbnZYUXlyWmtZazE0?= =?utf-8?B?WFZWTVpDd00wRXc5NEVjUWhPQmQzeUxXNWFVWERGcjFlejBsSU00ZDU2VDMv?= =?utf-8?B?bUd6K25SZyt2RUE0aElEYkdKeDJxOEpYZS9ndUJMbmNlRTdxaE1ObG51eHRr?= =?utf-8?B?SG9waytEclJLZWpPb0NLcXVYaWtrTUlaWVJrZmEvWVVid2lzU3N6Wkp4K29s?= =?utf-8?B?MWxnV25QbVUwRXJEa1oxdnBLWEQvRm1nVGlCYTdTU3ZZSmFrcjVMektQOW9T?= =?utf-8?B?TGd6MzFBWFA0MVJMbmRMNXBudUs2azU1YnY5ZllHdndTQTI5NzN4b0NPL0lW?= =?utf-8?B?QWU5RjlkOFpPQWVyaGcxb0l5c3RkSXhtSEkvRWJwcm9nZmJ2Qy95UjJLWHFN?= =?utf-8?B?Nk8raDlKdkZjK1FrQjh5bjlXeDB1YXNlTjZvbWU5OXZ0ZG1WbXZiaFJKdXJr?= =?utf-8?B?Q1BCK2J5Vjd2cXRFVFZERjhNYkJ0QUJKeEtzM0JSTTRjK3lqOUpzV3U5K0I3?= =?utf-8?Q?3VaqghxLAXh6N7TjnV518s3hV?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6adcb9-5482-42c6-97a0-08db3d07ad9d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 16:45:39.2079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jSCRh3wOzFaen/cUSIBsGNgKVu3DWYkfdEOjyGgzFa0/8dZVu4SlyOcOd0+cQY2s X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8228 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/13/2023 2:27 PM, Nipun Gupta wrote: > enable the compilation of cdx bus > > Signed-off-by: Nipun Gupta > --- > drivers/bus/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build > index 6d2520c543..a78b4283bf 100644 > --- a/drivers/bus/meson.build > +++ b/drivers/bus/meson.build > @@ -3,6 +3,7 @@ > > drivers = [ > 'auxiliary', > + 'cdx', > 'dpaa', > 'fslmc', > 'ifpga', Why not squash this to the first patch? I think better to enable bus with the first patch and gradually expand the feature, this way each patch is checked that it builds fine. There are cases some interim patches can't be built successfully, which may required enabling after a few patches, but I think this is not the case.