From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 15A3D2C2C for ; Fri, 1 Jul 2016 10:57:26 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id v199so17675390wmv.0 for ; Fri, 01 Jul 2016 01:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NrfnbR4TsF8yZNAIPWmOwMBVt8vLtjbv5tCq6HcuDMw=; b=dizjuIkpfqu6IguW/52GP3W9ClxCf4+0q5VKkxp3Y1sAWCxavv2F08TnBa+ukFGKmX kWisArgbmIzs5YnUR0HkDhFNZGnPVbLWPJ8m3fd7lyhXqN71TwTdlVDhZAL23gC3v+UF AU3VbSgF9ZXuwc0xx1DAD86DskFnCZuxE5aw6Vlj4sYpGgz2kRM/o0MaUPSjI2J7o3zo qdLx1xlQAYJ5sQ+ZEtJwnnVfulgKRKpNxCfxhJNEdzMTTsEfwARy2ZXTZRNsqvTfTiKC 8alw9+dga4KvEiOlc6w+2hTJURqWPUabX2EntS8VFh+0fni3IuvNqqmy3hKc9de05gSE LR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NrfnbR4TsF8yZNAIPWmOwMBVt8vLtjbv5tCq6HcuDMw=; b=Jh+HnB6rcGZBU4pZjuZF0ZCOhFxufnqVK3VM1GH28TmWhhhaa53eyZp34qE/i8+raR Y1beSzyTMuvAPWQiEu6VyqmO6qtz9GUGe9HGfWSZ7a9eCaicaDG5kM9eKa/CbaurIZD2 k2eMA32oQWBHRd1ClK/mCTMEurz0fNZy/m3oHxlNBn60DaEETaaRQwj98Kho0fTGrqSM ezeXNgBxM2pByiIcVRJDtxZojSz5cc/+c9CrDYtEvOqCvqqwIpJXgdKRkb7jQMK9Vban wgU/TrNtAXfKlGDLpWzC+LScyGO2FgnL+xvmO6ZhTu76RMfvQtEy0qsTVKuKxzC3prN1 To5A== X-Gm-Message-State: ALyK8tIsr4OPTqz9ZzeMD5iWVmwO0bJqRSFmz6Sy7ottCZtoXtrUTuk6NeCckADELTEXf5wp X-Received: by 10.194.31.137 with SMTP id a9mr2817534wji.113.1467363445811; Fri, 01 Jul 2016 01:57:25 -0700 (PDT) Received: from [192.168.1.15] (LFbn-1-8274-170.w81-254.abo.wanadoo.fr. [81.254.171.170]) by smtp.gmail.com with ESMTPSA id d4sm1630816wjb.47.2016.07.01.01.57.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 01:57:25 -0700 (PDT) To: Thomas Monjalon , Bruce Richardson References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> <1613474.aBI9rN0qDz@xps13> Cc: dev@dpdk.org, keith.wiles@intel.com, Panu Matilainen From: Olivier MATZ Message-ID: <3fc02727-50d2-a6b6-8dcc-8c8d6a0b1d89@6wind.com> Date: Fri, 1 Jul 2016 10:57:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1613474.aBI9rN0qDz@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] mempool: rename functions with confusing names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 08:57:26 -0000 On 06/30/2016 10:05 PM, Thomas Monjalon wrote: > 2016-06-30 13:49, Bruce Richardson: >> The mempool_count and mempool_free_count behaved contrary to what their >> names suggested. The free_count function actually returned the number of >> elements that were allocated from the pool, not the number unallocated as >> the name implied. >> >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count >> >> In this patch, the new functions are added, and the old ones are marked >> as deprecated. All apps and examples that use the old functions are >> updated to use the new functions. > > The ThunderX driver uses rte_mempool_count and needs an update. > Except that, it looks good. > Yep, I don't see any other issue.