From: Thomas Monjalon <thomas@monjalon.net>
To: Moti Haimovsky <motih@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: improve Rx packet type offloads report
Date: Wed, 08 Nov 2017 20:56:03 +0100 [thread overview]
Message-ID: <4000150.53I7WZDMbS@xps> (raw)
In-Reply-To: <1510166831-153992-1-git-send-email-motih@mellanox.com>
08/11/2017 19:47, Moti Haimovsky:
> This patch improves Rx packet type offload report in case the device is
> a virtual function device.
> In these devices we observed that the L2 tunnel flag is set also for
> non-tunneled packets, this leads to a complete misinterpretation of the
> packet type being received.
> This issue occurs since the tunnel_mode is not set to 0x7 by the driver
> for virtual devices and therefore the value in the L2 tunnel flag is
> meaningless and should be ignored.
>
> Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads")
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> V2:
> Modification according to inputs from Adrien Mazarguil
> * Modified the commit message to explain the issue.
> * Removed redundant l2 tunnel offload bit.
> * Modified mlx4_dev_supported_ptypes_get to report the supported
> packet types according to the device in hand.
> ---
As it is a v2, it should be threaded with v1.
Please remind to use --in-reply-to.
Just looking at the title, we should not take it for RC3.
But reading the commit message, especially "this leads to a
complete misinterpretation of the packet type being received",
it appears fixing a real bug. In this case, the title should be
"net/mlx4: fix Rx packet type offloads"
next prev parent reply other threads:[~2017-11-08 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 18:47 Moti Haimovsky
2017-11-08 19:56 ` Thomas Monjalon [this message]
2017-11-09 8:59 ` [dpdk-dev] [PATCH v3] net/mlx4: fix Rx packet type offloads Moti Haimovsky
2017-11-09 9:18 ` Adrien Mazarguil
2017-11-10 2:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4000150.53I7WZDMbS@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).