From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C9D2C1B283 for ; Wed, 8 Nov 2017 20:56:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E72A20A79; Wed, 8 Nov 2017 14:56:04 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 08 Nov 2017 14:56:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Qdpfid7zljTomVkqRD2CpJin3y 37mjLHpZShiy6k/9I=; b=W2i3T/W/u/0I26OeUrK1ec4l2HFK5932V6LqMyJ3a8 OOGAsrJroLDiGJwfhWH+AY6GL8oo4i863/xfpmGKewL2E/loVrAaLdAqGrHoTEBm 8CevzEXM3/MVl4fY2oTwCLaj3fk+9i3jXu6lm2qu0Ida9us0jwIXyWooqyENILL5 A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Qdpfid 7zljTomVkqRD2CpJin3y37mjLHpZShiy6k/9I=; b=ds5U77RPHeE88UXrd3Fwjh baN1ZuLL/r01uL2f4KTwAH93hS3IZWJGm8dU6UzmjSZqhKFLEYDudh6HMPQY9B1P H/5FgqCRqmywb7iYRA8FprxTR5vi+iACC7UUAU/h+76Ra+VnAWySmJTWXC7AELsA xqi7frzpfM++p8xt+NIHmyun0W/FcEQFDCJHJnBtwN57HJy0KkSX9aw3ExHFuLJw AxZG8GRkTyZJRNo4s8zcDJ6i2aJY0mMRXsrfR7j0S6N/UxFUKqcy9oBv0sY8xFaS GIyx9I1wPZTr6ezskaWAz2QJvSdsm1tv9l0aNYUfWAYwvtC7TKWuW/oprUYDujGA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A48B24740; Wed, 8 Nov 2017 14:56:04 -0500 (EST) From: Thomas Monjalon To: Moti Haimovsky Cc: dev@dpdk.org, adrien.mazarguil@6wind.com Date: Wed, 08 Nov 2017 20:56:03 +0100 Message-ID: <4000150.53I7WZDMbS@xps> In-Reply-To: <1510166831-153992-1-git-send-email-motih@mellanox.com> References: <1510166831-153992-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: improve Rx packet type offloads report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 19:56:05 -0000 08/11/2017 19:47, Moti Haimovsky: > This patch improves Rx packet type offload report in case the device is > a virtual function device. > In these devices we observed that the L2 tunnel flag is set also for > non-tunneled packets, this leads to a complete misinterpretation of the > packet type being received. > This issue occurs since the tunnel_mode is not set to 0x7 by the driver > for virtual devices and therefore the value in the L2 tunnel flag is > meaningless and should be ignored. > > Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads") > > Signed-off-by: Moti Haimovsky > --- > V2: > Modification according to inputs from Adrien Mazarguil > * Modified the commit message to explain the issue. > * Removed redundant l2 tunnel offload bit. > * Modified mlx4_dev_supported_ptypes_get to report the supported > packet types according to the device in hand. > --- As it is a v2, it should be threaded with v1. Please remind to use --in-reply-to. Just looking at the title, we should not take it for RC3. But reading the commit message, especially "this leads to a complete misinterpretation of the packet type being received", it appears fixing a real bug. In this case, the title should be "net/mlx4: fix Rx packet type offloads"