Re: [dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-11-25 12:43, Ferruh Yigit:
> On 11/25/2016 12:02 PM, Andrew Rybchenko wrote:
> > On 11/25/2016 01:24 PM, Ferruh Yigit wrote:
> >> On 11/23/2016 7:49 AM, Andrew Rybchenko wrote:
> >>> On 11/23/2016 03:02 AM, Ferruh Yigit wrote:
> >>>> Also folder structure is drivers/net/sfc/efx/<all_src_files>, why /sfc/
> >>>> layer is created?
> >>>> sfc is company name (solarflare communications), right? Other driver
> >>>> folders not structured based on company, what about using
> >>>> drivers/net/efx/* ?
> >>> I've tried to explain it above in item (2):
> >>>
> >>>  >>>
> >>>
> >>>   2. Another Solarflare PMD with in-kernel part (for control operations)
> >>>      is considered and could be added in the future. Code for data path
> >>>      should be shared by these two drivers. libefx-based PMD is put into
> >>>      'efx' subdirectory to have a space for another PMD and shared code.
> >>>
> >>> <<<
> >>>
> >>> So, main reason is to have location for the code shared by two Solarflare
> >>> network PMDs. May be it better to relocate when we really have it.
> >>> I'm open for other ideas/suggestions.
> >> If there will be another PMD that shares code with current one, the
> >> logic seems good, but I am not sure about start using company names, I
> >> am not against it, just I don't know.
> > 
> > I think that mlx4 and mlx5 are tightly bound to the company name (plus
> > adapter generation, I guess).
> > 
> >> Let's relocate later, this buys some time to think / get feedback on issue.
> > 
> > Do I understand correctly that you suggest to avoid extra level inside
> > for now
> > and relocate later if required? If so, that's fine for me.
> > 
> > As for naming, we think that just "efx" is a bad idea. The prefix is
> > occupied by
> > the libefx functions and driver should use something else. We have chosen
> > "sfc" mainly to follow naming used in Linux kernel for Solarflare driver
> > (the first level of Ethernet driver names is company bound in the Linux
> > kernel).
> > If we avoid extra level as discussed above, I think "sfc_efx", "sfcefx"
> > (may be it
> > will look better nearby other drivers) or just "sfc" are fine for us.
> > 
> 
> Thomas, Bruce, any comment on this?

You can add multiple drivers in the same library. As an example, ixgbe
directory have several drivers for PF/VF, scalar/vector, etc.
If you really want separate directories for your drivers while sharing some
code, you can link some files from the other directory.

About the name of this directory, I have no strong opinion.
sfcefx looks good.