From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wj0-f172.google.com (mail-wj0-f172.google.com [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 9394456B7 for <dev@dpdk.org>; Fri, 25 Nov 2016 14:00:18 +0100 (CET) Received: by mail-wj0-f172.google.com with SMTP id v7so58399584wjy.2 for <dev@dpdk.org>; Fri, 25 Nov 2016 05:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=YrNuTo0HO/0ksB2M9eAszdkmCq+XpaUUS+faZmQs2N0=; b=dPEBd/d+38t78v6rBypDKiXKNgKalTTT12L7AxBjzSuxdQqEXao+3vxaMzb/ELjIzS /pnpwBui4jgfAN+ISCn7L40GPIzTbdqmxnM08rGyreULqCL7cAfq51IQFv2wEXJuhLTI 03cDggbXOVB/wiVeO5h9dAanPLUhU+U/JN9MUn2cFuhJ8Gy401xmZenac/Hukomn50Ct DSeV8Xz4J25MlnMqgESNyGSdTZ8/RRWENqmqNb6l+rVDuFpBk4bVR/m7QKNHeLw6IjRn el/exSQTUe9JPEUisZV6Teb+Y+Kim4LGsrro5PJoIvyYsVymPYaol4+Y2NVkD8UMOykK PJNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=YrNuTo0HO/0ksB2M9eAszdkmCq+XpaUUS+faZmQs2N0=; b=mrqr4/Yaqm6IXTBzheuK9mDnL30yvUV1qJ2hPQy3f5Zh6LiboHOdalDQjpTQj1A2gq vaDPVAQfIbt75zih4a69BWJteJ8yX1lkfd0aYBojZbnHxBJIsppRnmIagNe3Tn+YatNK vdoykJGrnyL3dihH4kk1uOV4THtAxWUY5NmieaEA7XkFI1StpoGigxVwczCCMvWjUSBb gycJgnN6ctPvEl7FNfKsikcMUUv3zS2Y6YyUBkBus2uNd0wpX0TnxUtJmO70j6dt1wTq BeihXQAR4ys5nTac+DcvIvjnKMB0cyDI49Ve7MpsalAAyt3JREKGOf4UBB/iVB/+2Zwc 3zmA== X-Gm-Message-State: AKaTC022wOl6xln6on5MxLYcfq+EuTWhfzG2pCoAH+/ipXA469rG9Z9zhfOSoa8j7O2RWUqN X-Received: by 10.194.71.228 with SMTP id y4mr8267961wju.136.1480078818013; Fri, 25 Nov 2016 05:00:18 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f76sm13345658wmd.15.2016.11.25.05.00.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Nov 2016 05:00:17 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Andrew Rybchenko <arybchenko@solarflare.com> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Date: Fri, 25 Nov 2016 14:00:16 +0100 Message-ID: <4008902.bqyKbWRKzy@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <bf0be13a-c424-a559-1c9e-43fff3df3c65@intel.com> References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <edfdf094-9c4d-b019-2239-5d6c94722384@solarflare.com> <bf0be13a-c424-a559-1c9e-43fff3df3c65@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 25 Nov 2016 13:00:18 -0000 2016-11-25 12:43, Ferruh Yigit: > On 11/25/2016 12:02 PM, Andrew Rybchenko wrote: > > On 11/25/2016 01:24 PM, Ferruh Yigit wrote: > >> On 11/23/2016 7:49 AM, Andrew Rybchenko wrote: > >>> On 11/23/2016 03:02 AM, Ferruh Yigit wrote: > >>>> Also folder structure is drivers/net/sfc/efx/<all_src_files>, why /sfc/ > >>>> layer is created? > >>>> sfc is company name (solarflare communications), right? Other driver > >>>> folders not structured based on company, what about using > >>>> drivers/net/efx/* ? > >>> I've tried to explain it above in item (2): > >>> > >>> >>> > >>> > >>> 2. Another Solarflare PMD with in-kernel part (for control operations) > >>> is considered and could be added in the future. Code for data path > >>> should be shared by these two drivers. libefx-based PMD is put into > >>> 'efx' subdirectory to have a space for another PMD and shared code. > >>> > >>> <<< > >>> > >>> So, main reason is to have location for the code shared by two Solarflare > >>> network PMDs. May be it better to relocate when we really have it. > >>> I'm open for other ideas/suggestions. > >> If there will be another PMD that shares code with current one, the > >> logic seems good, but I am not sure about start using company names, I > >> am not against it, just I don't know. > > > > I think that mlx4 and mlx5 are tightly bound to the company name (plus > > adapter generation, I guess). > > > >> Let's relocate later, this buys some time to think / get feedback on issue. > > > > Do I understand correctly that you suggest to avoid extra level inside > > for now > > and relocate later if required? If so, that's fine for me. > > > > As for naming, we think that just "efx" is a bad idea. The prefix is > > occupied by > > the libefx functions and driver should use something else. We have chosen > > "sfc" mainly to follow naming used in Linux kernel for Solarflare driver > > (the first level of Ethernet driver names is company bound in the Linux > > kernel). > > If we avoid extra level as discussed above, I think "sfc_efx", "sfcefx" > > (may be it > > will look better nearby other drivers) or just "sfc" are fine for us. > > > > Thomas, Bruce, any comment on this? You can add multiple drivers in the same library. As an example, ixgbe directory have several drivers for PF/VF, scalar/vector, etc. If you really want separate directories for your drivers while sharing some code, you can link some files from the other directory. About the name of this directory, I have no strong opinion. sfcefx looks good.