From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix compile issue on Ubuntu 12.04 with kernel 3.13.0-30
Date: Tue, 24 Nov 2015 21:36:33 +0100 [thread overview]
Message-ID: <4010980.uDg8NWFa2X@xps13> (raw)
In-Reply-To: <1448384381-203269-1-git-send-email-pablo.de.lara.guarch@intel.com>
2015-11-24 16:59, Pablo de Lara:
> Fixes following error when Ubuntu 12.04 uses kernel 3.13.0-30-generic,
> since skb_set_hash() is implemented in the kernel from 3.13.0-30,
> which is declared as UBUNTU_KERNEL_VERSION(3,13,0,30,0) and not
> UBUNTU_KERNEL_VERSION(3,13,0,30,54)
>
> In file included
> from /usr/src/linux-headers-3.13.0-30-generic/include/linux/if_ether.h:23:0,
> from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:39,
> from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31,
> from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:31,
> from /tmp/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mbx.h:31,
> from /tmp/dpdk/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/e1000_mbx.c:28:
> /usr/src/linux-headers-3.13.0-30-generic/include/linux/skbuff.h:740:1:
> note: previous definition of ‘skb_set_hash’ was here
> skb_set_hash(struct sk_buff *skb, __u32 hash, enum pkt_hash_types type)
> ^
>
> Fixes: e88c3b0a ("kni: fix build on Ubuntu 12.04.5")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-11-24 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 16:59 Pablo de Lara
2015-11-24 20:36 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4010980.uDg8NWFa2X@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).