From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 978D9ADBE
 for <dev@dpdk.org>; Tue, 27 May 2014 10:48:57 +0200 (CEST)
Received: by mail-wi0-f174.google.com with SMTP id r20so1223002wiv.7
 for <dev@dpdk.org>; Tue, 27 May 2014 01:49:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=FIhnan3M1hOOZKQvVimC9gN+t4L//TxYWdz7F5hGpZ4=;
 b=TqkaFKQMSfzHXLDhitDHjEtywcsQF7nqJtwjSlvpbIAiv17qR7DXthOggQ4OINtHMQ
 a1vr743inX30smemE8QsZQi8rTLSlJ8rCdDn3l+WXwP+vxl9A2gntmEU2zxqzk3ZV9mE
 W15p0LPSU4fZ6hdGdWuJ0dfi1A6voQjW+IFQb/LYWOipRlPLahaT3NCostC2i86vThcJ
 tGr2DK2oPbWdVzRckq4GhxRksMJRXyuBXKxcgGbonF3ER23bRzvbck4j9lcprT+5wFBb
 ab5XAAbtKC0mVFoAaq6bEG2UT9/R1ogq0InsjZYAy5T9r7z656+b0ryQdBuv0KDX8xCc
 Ep7w==
X-Gm-Message-State: ALoCoQmsykGBSWVYhlPo6UoxhDg8Uw843VDJGcY6OkqmUSYs4XVaG09pUkhAe6isvgv3ME88wo00
X-Received: by 10.180.37.198 with SMTP id a6mr19926886wik.58.1401180546263;
 Tue, 27 May 2014 01:49:06 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id jr1sm33362747wjc.13.2014.05.27.01.49.04
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 27 May 2014 01:49:05 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Tue, 27 May 2014 10:49:01 +0200
Message-ID: <4015459.eKTdkh5M37@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A46F69410@SHSMSX101.ccr.corp.intel.com>
References: <DF2A19295B96364286FEB7F3DDA27A46F69410@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 04/16] Make igb_uio compilation optional
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2014 08:48:57 -0000

Hi HuilongX,

I have few comments.

2014-05-27 02:43, Xu, HuilongX:
> Currently, igb_uio is always compiled. Some Linux distribution may
> not want to include igb_uio by default, so we need to make sure that
> igb_uio compilation can be optional.

1) When replying to an email, there should be "> " in front of lines you have 
not written. Here, it's not easy to see what you are replying.

> Signed-off-by: Anatoly Burakov
> <anatoly.burakov@intel.com<mailto:anatoly.burakov@intel.com>>

> Test-by: HuilongX Xu <huilongx.xu@intel.com<mailto:huilongx.xu@intel.com>>
> Compile
> pass
> 
>      >>Compile OS: FC20 x86_64
>      >>Kernel version: 3.13.6-200
>      >>GCC version: 4.8.2
>      >>Server: Crownpass

2) Please do not copy all the patch if you have nothing specific to say about 
it.

-- 
Thomas