* [dpdk-dev] [PATCH] lib: remove sched.h from public headers
@ 2021-08-28 22:13 Dmitry Kozlyuk
2021-09-23 22:34 ` William Tu
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Kozlyuk @ 2021-08-28 22:13 UTC (permalink / raw)
To: dev; +Cc: Dmitry Kozlyuk, Ciara Power
Public headers including POSIX-specific <sched.h> were unusable
on Windows. These includes were superfluous, remove them.
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
lib/eal/include/rte_eal.h | 1 -
lib/telemetry/rte_telemetry.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h
index eaf6469e50..0c43a0a2c1 100644
--- a/lib/eal/include/rte_eal.h
+++ b/lib/eal/include/rte_eal.h
@@ -12,7 +12,6 @@
*/
#include <stdint.h>
-#include <sched.h>
#include <time.h>
#include <rte_config.h>
diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
index 8776998b54..1cdc903f38 100644
--- a/lib/telemetry/rte_telemetry.h
+++ b/lib/telemetry/rte_telemetry.h
@@ -3,7 +3,6 @@
*/
#include <stdint.h>
-#include <sched.h>
#include <rte_compat.h>
--
2.29.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers
2021-08-28 22:13 [dpdk-dev] [PATCH] lib: remove sched.h from public headers Dmitry Kozlyuk
@ 2021-09-23 22:34 ` William Tu
2021-10-01 6:36 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: William Tu @ 2021-09-23 22:34 UTC (permalink / raw)
To: Dmitry Kozlyuk; +Cc: dpdk-dev, Ciara Power
On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> Public headers including POSIX-specific <sched.h> were unusable
> on Windows. These includes were superfluous, remove them.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
Write a program, include rte_eal.h, link with DPDK library, then
hit the issue. Verify the patch works correctly and solve my problem.
Acked-by: William Tu <u9012063@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers
2021-09-23 22:34 ` William Tu
@ 2021-10-01 6:36 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-10-01 6:36 UTC (permalink / raw)
To: Dmitry Kozlyuk, Ciara Power; +Cc: dev, William Tu
24/09/2021 00:34, William Tu:
> On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> > Public headers including POSIX-specific <sched.h> were unusable
> > on Windows. These includes were superfluous, remove them.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
>
> Write a program, include rte_eal.h, link with DPDK library, then
> hit the issue. Verify the patch works correctly and solve my problem.
>
> Acked-by: William Tu <u9012063@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-01 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-28 22:13 [dpdk-dev] [PATCH] lib: remove sched.h from public headers Dmitry Kozlyuk
2021-09-23 22:34 ` William Tu
2021-10-01 6:36 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).