From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 723A58E83
 for <dev@dpdk.org>; Thu, 26 Nov 2015 22:29:25 +0100 (CET)
Received: by wmec201 with SMTP id c201so36320003wme.1
 for <dev@dpdk.org>; Thu, 26 Nov 2015 13:29:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=LaieEJmBMQ9ml2GgUI+ZLZPgShTEwIbUsgoi6AF8CGw=;
 b=VA7orjORjs7veM9kEciuaMNF5m2wJleIRXso1K2sCbw5oWgEsBD+gCLsvMUMXR+cYk
 3IbJiXDjo6z+3PLavX5C14v4ZFSeN8NbHacgO+cRemX5AaDT9IwMvn84ormJYpoz15AZ
 PrRQ9c3QX/y3UDp/SaV6sR2DXGtQYD6tYWvODHRdb1SToOp3fh/zu4gAzVXyE1RnK8no
 FlEl3Nv96GEkTkBAP3C49YsTFQPFBDVbeyRf+6+jU2R1Ci+U7K07iuxbQBDBU6gfQkUU
 i8vW0qA5WVESooulzZbZnBQXYmO7FpB7V9EY9img5El2rXyvll4u6t9RWLHpq1aMzGAF
 qsNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LaieEJmBMQ9ml2GgUI+ZLZPgShTEwIbUsgoi6AF8CGw=;
 b=d2MPWLd6W+LVsod3i6O7ESf0XOpM8jBKeh/Q1ZRTId9Hegn4BaixtRt8uKO1GVIKQB
 RnzM1nj66X0hMFSKbbLAUoR18YCAG0IAFB9+Uk5SA/vO7he+Kk7UhXlnkpLGYBhWoCiS
 gIulo9woqN9JfniwkZxPiWSzwMk/nxJh0Vvn0CVep4PnFxVp6FcvoJ6T8c4kSmAwx6TI
 fy8djtpJhDNy7NikX0/z6vd1AG1lYnVDRYFGIwtixXNFmKorPWIJpGLhYz1kE1dzo1O2
 IrqB6nJhWOmJm4P5jBaxX0b97sHs4jFUK86MWKv/oVizmX1Y95i2B1EOG1i+npVM6Dz1
 tOAQ==
X-Gm-Message-State: ALoCoQlXwVJuJyBtY+mCqOHcIXo4AqpWLahg3Ajr2jjzweWBHh3XyBRfUdLIxkdcgw3EyJFpb5gz
X-Received: by 10.194.188.112 with SMTP id fz16mr58439313wjc.65.1448573365314; 
 Thu, 26 Nov 2015 13:29:25 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id t2sm5032755wmt.1.2015.11.26.13.29.24
 (version=TLSv1/SSLv3 cipher=OTHER);
 Thu, 26 Nov 2015 13:29:24 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Date: Thu, 26 Nov 2015 22:28:06 +0100
Message-ID: <40264692.U54vlS2tjY@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1448534997-24297-1-git-send-email-michael.qiu@intel.com>
References: <1448534997-24297-1-git-send-email-michael.qiu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Nov 2015 21:29:25 -0000

2015-11-26 18:49, Michael Qiu:
> gcc 4.3.4 does not include "immintrin.h", and will post below error:
>     lib/librte_sched/rte_sched.c:56:23: error:
>     immintrin.h: No such file or directory
> 
> To avoid this issue, a gcc version check is need and a flag to indicate
> vector ablility.
[...]
> +#if (defined(__ICC) || (__GNUC__ == 4 &&  __GNUC_MINOR__ < 4))
> +
> +#if defined(__AVX__)
>  #include <immintrin.h>
> +#define SCHED_VECTOR_ENABLE
> +#endif
> +
> +#else
> +
> +#include <x86intrin.h>
> +#define SCHED_VECTOR_ENABLE
> +
> +#endif

This kind of complication is managed by EAL.
I think we should include rte_vect.h.