From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 117C01B6DE for ; Fri, 13 Oct 2017 15:54:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4B4B520C4A; Fri, 13 Oct 2017 09:54:32 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 09:54:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=7loAUPJt9AKbzj/pbL6wRdKaAh BydAEQS0NyKfsgiAE=; b=cKkRgvFHysHW17CyOvAIvAAtzGhaeKx0mbJGwh3bUF /9wWdX5BEIOxfnb6UmxOUxbwCfxtskWusngTrelqtNOBk9PnreEh3raDK+31T4hW Pj4YBZPlMFxr53pADygRUDaOtyT8Gc5eOsrSJLM+67wE1bpt33ZAAr8Lt3pqzJEg M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7loAUP Jt9AKbzj/pbL6wRdKaAhBydAEQS0NyKfsgiAE=; b=cGx2884JfuR6E6kmv7qrOb 585Wi9DvhlwztrO76Oi2Lw/fzfYoGGsZmvwCJopaQUD9ElppaYGEocD32zvLlAwv SdNHuEGi+Ec301KLAegSBGbJXo2mgXITNHxlYn3iupqpHc0Xn39T6x9u9jDAlIsk Nhr9C02oTt0a5ywfEIRNiEev3EnpUGmtN/MK1nfWUfwFHDm+jyGBDfRBBewInk1z 3m8B6i0AV4VzkWC1/1Vxh1thQWEG6nU/wD2tCAt0erVrQVwHQtCJnaauM9wKdHWx 0j/i7ptJM7uIkaC/yXqeNtqUj7zba+VkG1bCXRge23c540504GFTVsaJRCN+aBjA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DFF462484E; Fri, 13 Oct 2017 09:54:31 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Patrick MacArthur , mark.b.kavanagh@intel.com, stephen@networkplumber.org, markus.theil@tu-ilmenau.de, Patrick MacArthur , Bob Noseworthy , "O'Driscoll, Tim" Date: Fri, 13 Oct 2017 15:54:30 +0200 Message-ID: <4026806.rrLJ8tnTkl@xps> In-Reply-To: <7673fa98-986e-abde-a68c-01809d01caec@patrickmacarthur.net> References: <20171013024644.51248-1-ferruh.yigit@intel.com> <7673fa98-986e-abde-a68c-01809d01caec@patrickmacarthur.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix unknown symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 13:54:33 -0000 13/10/2017 05:21, Patrick MacArthur: > On 10/12/2017 10:46 PM, Ferruh Yigit wrote: > > This patch partially reverts the commit d196343a258e and adds some > > functions from Markus' previous version of the patch [1]. > > > > igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs > > when kernel version is >= 3.19 because these APIs are implemented in > > this Linux kernel version. > > > > But these APIs only exported beginning from Linux kernel 4.5, so before > > this Linux kernel version igb_uio kernel module is not usable, > > and giving following warnings: > > "igb_uio: Unknown symbol pci_msi_unmask_irq" > > "igb_uio: Unknown symbol pci_msi_mask_irq" > > > > The support for these APIs increased to Linux kernel >= 4.5 > > > > For older version of Linux kernel unmask_msi_irq() and mask_msi_irq() > > are used but these functions are not exported at all. > > Instead of these functions switched back to previous implementation in > > igb_uio for MSI-X, and for MSI used igbuio_msi_mask_irq() from [1]. > > > > Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X") > > Cc: markus.theil@tu-ilmenau.de > > > > [1] > > http://dpdk.org/dev/patchwork/patch/28144/ > > > > Signed-off-by: Ferruh Yigit > > I can confirm that with this patch applied I am able to build and load > the igb_uio module on CentOS 7.4. I have not tested the actual MSI-X > interrupt mask/unmask functionality. Applied shortly without more tests to make it part of RC1, thanks