Re: [dpdk-dev] [PATCH 2/2] ethdev: remove old flow director symbols

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-12-15 13:41, Panu Matilainen:
> On 12/15/2015 12:47 PM, Thomas Monjalon wrote:
> > The API has been removed but the symbols were still declared in the map.
> >
> > Fixes: a421b86a4a02 ("ethdev: remove old flow director API")
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> >   lib/librte_ether/rte_ether_version.map | 8 --------
> >   1 file changed, 8 deletions(-)
> >
> > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> > index 17a11c7..d8db24d 100644
> > --- a/lib/librte_ether/rte_ether_version.map
> > +++ b/lib/librte_ether/rte_ether_version.map
> > @@ -27,14 +27,6 @@ DPDK_2.2 {
> >   	rte_eth_dev_count;
> >   	rte_eth_dev_default_mac_addr_set;
> >   	rte_eth_dev_detach;
> > -	rte_eth_dev_fdir_add_perfect_filter;
> > -	rte_eth_dev_fdir_add_signature_filter;
> > -	rte_eth_dev_fdir_get_infos;
> > -	rte_eth_dev_fdir_remove_perfect_filter;
> > -	rte_eth_dev_fdir_remove_signature_filter;
> > -	rte_eth_dev_fdir_set_masks;
> > -	rte_eth_dev_fdir_update_perfect_filter;
> > -	rte_eth_dev_fdir_update_signature_filter;
> >   	rte_eth_dev_filter_ctrl;
> >   	rte_eth_dev_filter_supported;
> >   	rte_eth_dev_flow_ctrl_get;
> >
> 
> Good spotting. What did you use find these and the ones in eal? Just 
> thinking this seems like something that could and should be automated.

Yes, it must be automated.
There are also some symbols which are defined in headers and do not need
to be in the .map. I'll send more cleanup and the script in the coming days
(for 2.3).