From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DADCFA04A5; Wed, 17 Jun 2020 10:19:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 052B41252; Wed, 17 Jun 2020 10:19:02 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C3A881150 for ; Wed, 17 Jun 2020 10:19:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5F3815C00FF; Wed, 17 Jun 2020 04:19:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 17 Jun 2020 04:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= IvjAsRqET2CjmSD4/D5Ii9kmZu0viY3BA4+/k5m6tbk=; b=RxZNBacza35YhzPG dJhwgON+5br7nmciFll4F5/PlacYD0fOQxHpcCueqmQS3fz9mrNJMPzQgnYBGFI/ llgb/ZRBKbg7EiDY0iauFudlk0qfhEaOdF3V7pVbM1dSMbW9lfoO8jRI1IKUXhB3 AlkwHMNXgoa8eSJOIRLupCc6GoDwpbLQs9Je8qcIt5NuKycZymUnBpHmPugSVnSd DXsEwTMllSADymKld6SBS9tBnyQS3/0g+UU6X+EJwbErSwi8DHR5gd8qHjF372vi rFze0kLOjYhL4jullKlmompbVM1qTbSJFxyFok5EsCBNvih+8VpXKWOUTtGeHPAw /guLbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=IvjAsRqET2CjmSD4/D5Ii9kmZu0viY3BA4+/k5m6t bk=; b=s8w/et/wHm08dzTVlAXq3rqG+/pehKuavyT+SEsBy6Qs2ztMy5fzuMwDy yGrRsGM/L/WmpryAlIq84ay8f13D6i2alxdQoR3RXjcBSOdEFEvjB05u8JWvQv7U tZSXe2G5e6X83uzJmr+86HuoKbfwaX6PQI4NGDMo5YjSzSszvbzOZifibUHwp5fR 2BuLVytRhaCZcFjwyYBmsOCqt0Cngx7ZTqfmWdKYDVO7/aezxT3OGiVo1ZHaXhFW Jy3XQxbosX0dVh88vKHyARJ6GNAGWrQVfphdGMT21euhsa7QxYe/+8z8GIvBgJdi Bf4FVTbngTSRmiSkskyIxfMELxpPw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 48F3E3061DC5; Wed, 17 Jun 2020 04:18:59 -0400 (EDT) From: Thomas Monjalon To: Parav Pandit , =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org, ferruh.yigit@intel.com, orika@mellanox.com, matan@mellanox.com Date: Wed, 17 Jun 2020 10:18:58 +0200 Message-ID: <4042779.WuHiVtWF6s@thomas> In-Reply-To: <20200615214631.lmubncrd6xggq3hu@u256.net> References: <20200610171728.89-1-parav@mellanox.com> <20200610171728.89-6-parav@mellanox.com> <20200615214631.lmubncrd6xggq3hu@u256.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/06/2020 23:46, Ga=EBtan Rivet: > On 10/06/20 17:17 +0000, Parav Pandit wrote: > > + DRV_LOG(ERR, "Invalid mlx5 classes %s. Maybe typo in device" > > + " class argument setting?", value); >=20 > Error message should not be cut in half, it makes it difficult to grep. > If you differentiate between typo in name and invalid combo you could > directly warn the user about the proper error. >=20 > (You can ignore the warning from checkpatch.sh about the long lines on a > string if there is one.) The best is to cut the message after variable placeholder. Here you can cut at the end of the first sentence "%s. "