From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 495A0A0588; Thu, 16 Apr 2020 00:19:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D408B1D663; Thu, 16 Apr 2020 00:19:46 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0B2491D659 for ; Thu, 16 Apr 2020 00:19:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 892CD5C0117; Wed, 15 Apr 2020 18:19:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 15 Apr 2020 18:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=926KJxpBE01ko9xLbTxnTove2AJm12unPnEiz7Aw+wg=; b=ZD/mNxzoyzRe AycVgl6s3uPLfEhNR1U5m2FwVEfYdZWHptnH5AcBbN2pqTbGLGLCjnW4UMxdvfpt 0zQtho5NkTYuvglJPPSNdJyIu+oA9PQH/f1dk9/IqvWlB0kKszyRDDMe5Ro2QD2p 7b4rup2n8M/sWjN9vAdvQaZL7lsAdko= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=926KJxpBE01ko9xLbTxnTove2AJm12unPnEiz7Aw+ wg=; b=NB+WRg3FQRefMUV6sAOs8fP8CCWtastliJEOhcXIZtgA9G9PAGkYSDcbZ MRrZbykAzU4B3f8RSIlISKkotWzv7qFWXBdEoCgYuApv9cwW5IvPdEHmBfYLGfJ/ OqXqwD5yOX5DEmO4XqSIImiILEDsIze71dKPE8RMSWH1LZAFvkKk9BAn6V4GJBBo xwwRwGKwBWVFlzzHGenn6pl2YenHwldNtzc4ahOyNjt5+u64aOvOXUraTKjtHH/b Z7NqIrmYHQhzgtiQ4mSje1KrdeLg//zSVq9wactN/ww56ZLvIeSwAvdBISjUnltn phxjGu1hEBa/7fcSm4YMyMAbm2cDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeeggddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E5023060074; Wed, 15 Apr 2020 18:19:42 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov , Bruce Richardson Date: Thu, 16 Apr 2020 00:19:41 +0200 Message-ID: <4043043.XrmoMso0CX@thomas> In-Reply-To: <20200414194426.1640704-8-dmitry.kozliuk@gmail.com> References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-8-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 07/10] eal: extract common code for memseg list initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 21:44, Dmitry Kozlyuk: > All supported OS create memory segment lists (MSL) and reserve VA space > for them in a nearly identical way. Move common code into EAL private > functions to reduce duplication. > > Signed-off-by: Dmitry Kozlyuk > --- > lib/librte_eal/common/eal_common_memory.c | 54 ++++++++++++++++++ > lib/librte_eal/common/eal_private.h | 34 ++++++++++++ > lib/librte_eal/freebsd/eal_memory.c | 54 +++--------------- > lib/librte_eal/linux/eal_memory.c | 68 +++++------------------ > 4 files changed, 110 insertions(+), 100 deletions(-) Didn't review this change, but thanks for doing such cleanup.