From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86321A0524; Tue, 13 Apr 2021 15:10:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C6A8160F5E; Tue, 13 Apr 2021 15:10:57 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 71C33160F56 for ; Tue, 13 Apr 2021 15:10:56 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 512335C0136; Tue, 13 Apr 2021 09:10:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 13 Apr 2021 09:10:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= tsrEodzJzLJ+bUk9fZNpZZ3wf4WaLrFYZ84MZ9zaXsM=; b=jpvMVd+OBrTJu4bp VIRjASfx2s31oAtic/F1RSHt/z/iEyR3dLPG71CBm4uedzukN/5GdpWZTj7K3rsV 5+awBELu8tR9yFR+gbwfuqfj2PhUQuRGgai0hN+afLVvHK1ZNMpJaH5oOJoHu9gd Sg4DiCeCshvDiFSnCdV0GedefwDcGkD0aAMiVAtaQoSyrQ8TfEkdAc7/iiM39cRX IYofnAJzpKQcm2tV6fF27PqRXGEtBnWOmqZk+VVX8dJ7eMGEkjtEYXAKrtlbZt20 CmsUiyN38EjJ/wyPwEmO+UQwoovAzsdtGXe2Nu/a/7HryGdfUwQrGjq7wl574+Nl nWygcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tsrEodzJzLJ+bUk9fZNpZZ3wf4WaLrFYZ84MZ9zaX sM=; b=FZ2HuS28niWZ+diiNCXLATxrG/CE0xjawLXM/C/aS0bbKiqn2kpqTA86D 91uaKdlX/E2a501P40T50fHGHY/CF2H7MHPmAVKZSrVbUGXd0nwYCqxTz175KGAp kh1YutqMCILwTfbXIfVGU/88DRBmCZy1+mQz5Ki89Vt1GuAiTzT3unptaLq7WC+6 G4FbGLtHP95lEYhzBt0+GWGVBVmU7QwrFOqutI2l7t4w7NuqjF0NVxJ/YAwlvjXi x76HPylWRzd2HGFLLN6DEE1C+hVY8JXAAMbsUnahD6aGyd1v8NYWeNu1VyC5FvJl EvBClpmB8dc0Oj/rm+6maltjOld4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AECC41080063; Tue, 13 Apr 2021 09:10:50 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: Dmitry Kozlyuk , dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stephen@networkplumber.org, drc@linux.vnet.ibm.com Date: Tue, 13 Apr 2021 15:10:49 +0200 Message-ID: <404581054.2Ubleb3na6@thomas> In-Reply-To: <20210325185026.GA11101@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <6471682.gLmPldMPvt@thomas> <20210325185026.GA11101@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2021 19:50, Tyler Retzlaff: > On Thu, Mar 25, 2021 at 09:00:54AM +0100, Thomas Monjalon wrote: > > 25/03/2021 01:09, Tyler Retzlaff: > > > On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote: > > > > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > > > > > > > > Can't speak for Seastar and Click, but we never hit this particular issue. > > > > What is the minimal complete example to reproduce? > > > > > > interesting, i did a bit more digging and it is clear why. i'm consuming > > > headers and crt that have been enhanced to enforce c++ standards > > > compliance. after dumping the preprocessed output i suspect this cannot > > > be reproduced with the publicly available headers it seems i'm the only > > > "beneficiary" heh. > > > > > > so the minimal example is really just to #include after including > > > say rte_windows.h but it won't reproduce for public users of the sdk. > > > > > > if there is a great deal of concern with respect to compatibility i > > > guess as the single consumer who has this problem i can just #undef asm > > > since we don't use inline asm anyway. > > > > > > thoughts? > > > > No please don't do this. > > There is an issue in DPDK which must be fixed. > > It seems your patch is correct, I am waiting for confirmation of others. > > thanks, i'm glad for the desire to make the proper fix. we'll wait for > others to comment. Nobody dares to comment on the asm keyword, so I'll just take your patch with few more explanations.