From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7EE8A1BCDC; Thu, 20 Dec 2018 15:26:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DAA1F22247; Thu, 20 Dec 2018 09:26:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 09:26:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=n6j4+nm2PiwSMnzpku33YK7qV8FpfAaMUJnaSCC1VZk=; b=oc7+bqnsUtoD QUSaJqDhYNhmz11zVtwH89mcQyUweAEsvHIpgOI2k4x9MsIv+uO4RS7QRxgBL0lU cXOWddYlJaqTcQy6Y2qmyqiFXCISwhdGLEVb1wIQ0jHELJFAAfAKi8/KDx1YO4vw Yj1d5T/4ZSqA9lfuQkdBfLd73HKtpHM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=n6j4+nm2PiwSMnzpku33YK7qV8FpfAaMUJnaSCC1V Zk=; b=xygje9xSjaGGFQrHD3I/Jf7IMGO1tJy7mpYCZY21Bsi9U1V6jBSHcKyjN Vfn5LoJKXRp0JvnSl10fKkl1HmvzjxqDZY2SfZ2dPeAL3U5J6ujxT/ws7U3CGUnD 2hqg4n6/JIC8N1fFnCR1wF8X7nPzFiRKCUzPoRztwn+wa4xdYPLV9yTwz/Rf6xU6 PLTHWrNWubfLMWr1OwZ4Ra0TvzzeSvOgcVO7xIruuMCq/3OEfy0GP5sizZYiJLbw qFstGqdVlDXDVtuI+YQiP7KZFQ8JraT/wN+9+4qe1/3NEKBWPYGhD4RZMcoLcIcq 3gpPN88lEfli/MY6hFGug0f2f+WAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8DA1DE4366; Thu, 20 Dec 2018 09:26:57 -0500 (EST) From: Thomas Monjalon To: Seth Howell Cc: stable@dpdk.org, "Burakov, Anatoly" , dev@dpdk.org, Darek Stojaczyk , ktraynor@redhat.com Date: Thu, 20 Dec 2018 15:26:56 +0100 Message-ID: <4046247.fkW2E6NNR7@xps> In-Reply-To: <0f7b6cfb-e7d0-b511-b943-7f1b3b3eda2f@intel.com> References: <20181204170610.250124-1-seth.howell@intel.com> <20181207201042.372870-1-seth.howell@intel.com> <0f7b6cfb-e7d0-b511-b943-7f1b3b3eda2f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] malloc: notify primary process about hotplug in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 14:26:59 -0000 10/12/2018 11:49, Burakov, Anatoly: > On 07-Dec-18 8:10 PM, Seth Howell wrote: > > When secondary process hotplugs memory, it sends a request > > to primary, which then performs the real mmap() and sends > > sync requests to all secondary processes. Upon receiving > > such sync request, each secondary process will notify the > > upper layers of hotplugged memory (and will call all > > locally registered event callbacks). > > > > In the end we'll end up with memory event callbacks fired > > in all the processes except the primary, which is a bug. > > > > This gets critical if memory is hotplugged while a VFIO > > device is attached, as the VFIO memory registration - > > which is done from a memory event callback present in the > > primary process only - is never called. > > > > After this patch, a primary process fires memory event > > callbacks before secondary processes start their > > synchronizations - both for hotplug and hotremove. > > > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > > > > Signed-off-by: Seth Howell > > Signed-off-by: Darek Stojaczyk > > --- > > Lost my review tag... > > Reviewed-by: Anatoly Burakov +Cc: stable@dpdk.org Applied, thanks