From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 165BBA0C43; Tue, 11 May 2021 22:45:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 515984069C; Tue, 11 May 2021 22:45:21 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 569DF4003E; Tue, 11 May 2021 22:45:19 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A5FB25C011B; Tue, 11 May 2021 16:45:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 11 May 2021 16:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= TKA4F4GC8FOu3+bFa9pcfrW0zLbo59vfTxEuav49VMs=; b=wvn/Lqh5JNw+8YRs LxqOmTG4iYbcBtvFDRGADN3MJRIeztkXsggcCi9gmNSYhrOEr4Ris38i0PQqcvWS FtGBW96efl4cHchMqPkkDTep2szQZU1CRNg5Ksa5RcErEXoz0LcSsoq96QuBReDa M7lizkKJrWrjXzySJiwBusv0JOhMl0Zh+2cN+GBYkGijePj5Z7E3NgyCBBfLg2Fp S2dXs026FZMcxY7XQaPT4YGmX5iIbnNzgNJpR0/4ZySZD1OSHyDP6IlOGzNDVVp8 FekubQ3BingIlioWtLKheXLXy9FjX8DuiBdVzjWwrRxXD/RJyND4ISy7k/+RbrSU JAicPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TKA4F4GC8FOu3+bFa9pcfrW0zLbo59vfTxEuav49V Ms=; b=ie9T0elyLCI4jko3eZHbfyWqRkSl/PobMra7Miefxi5/ExQ3uvYwUYJHV xxPtsQGu1xjGT+m89ybm7P0PDK0Pjo/COFb2qwEBIuNz7MpePIVNn3YHvFjVKGXm FN/5PkrZJa1z6115QQxdJCyHG/FxjmH2RU+Jtj3D5lSXAhjzjGO3H+Thd/FofNZp +9XQfFjm2iSFwnC2T3T+6QUijU2iApuPgUu3g8lidbS7Qd9K/MV7X3hNrXNxjHXn UYF9Bp7+f62zyrVdOJRdxUuzfxQlwwr8uk34YRSKYPqC8F0Sqiu9tPcFjgSBm4rG f7hSmB3/9d+oOO6Cdb7DwwqBMmbnQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 16:45:16 -0400 (EDT) From: Thomas Monjalon To: Lance Richardson Cc: dev@dpdk.org, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , stable@dpdk.org, "Burakov, Anatoly" , david.marchand@redhat.com Date: Tue, 11 May 2021 22:45:13 +0200 Message-ID: <405193764.ikPIj9qm96@thomas> In-Reply-To: <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com> References: <20210507181025.84012-1-lance.richardson@broadcom.com> <2003089.4ItjxMFgZf@thomas> <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2021 17:31, Burakov, Anatoly: > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > +Cc Anatoly > > > > 08/05/2021 16:27, Lance Richardson: > >> For 32-bit targets, size_t is normally a 32-bit type and > >> does not have sufficient range to represent 64-bit offsets > >> that can are needed when mapping PCI addresses. Use uint64_t > >> instead. > >> > >> Found when attempting to run 32-bit Linux dpdk-testpmd > >> using VFIO driver: > >> > >> EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \ > >> 0x200000, 0x20000000000): Invalid argument ((nil)) > >> > >> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers") > >> Cc: stable@dpdk.org > >> Signed-off-by: Lance Richardson > >> --- > > LGTM, although the Fixes: tag is probably wrong because IIRC previous > versions did have the same issue. > > Acked-by: Anatoly Burakov v3 applied, thanks