From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id C567D5588 for ; Thu, 10 Mar 2016 17:25:38 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id l68so38001954wml.0 for ; Thu, 10 Mar 2016 08:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+/MMe7/dOVVZINvLVdaFN9aaBIySewAFkjCxhx6vVyI=; b=ya7XxVd69aNf4SAxfPLFLAKOGvr67RNmFUsT08KDqgpKIb2VvG4LPNpk3lUp3kXSQg DIt24O8/lo8LN3Ah2/ojzyqFLJvkcSiaIi5j1uXXijdrX931fvcvK0htCDBuAHPqubPZ RwbuYRFnMhBdFMb0NOZBGZ28/TDhvD2dc6JJfQrYbFMCi15MTJ9nJLhUYptzT2hf4q0Y y/qFszbisFANgLEMQnop2He+Tt11ynijAFtnILhGj1k1Jtpn1yCUMHJYOUl9IRmDM2Aj Zr0KstOtq1RztyhtJnBZnb+i82gPLQoIcdRxrN1eOhCYyBFrhZ0XGZJzjr6ZXcLDHV4s U4ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=+/MMe7/dOVVZINvLVdaFN9aaBIySewAFkjCxhx6vVyI=; b=d+xDgvoOJ+is9ViZSnZHhG3OoZFaXLQkbB+01OfuGq4Q1dYmt3jlxeQ3VkR+L/DOGg hCmugTC7te84ZKozr1L11XMgNtM5PyzrC0nccRAwXyLnPm+OUY6kwx36bD94X2quMsr2 nmdr0dH6vVzig/UJcIP/d+krXwUOTiy/uoWGM/i0t7BwfIi4rw//kgaoPibENrDZUyhQ 69KptcF7emWYqstMcmJJw+cearX6OW9XgOSz8c7xHB6y6dHOPnzaDqErdfyeWEY7vV6E Cv+BWgqf6dFuYP9DKQ9EC3lEybiZqfeU6IevF36c3qmdf7CQAy6rk0Y88+J7wghmvBES UftQ== X-Gm-Message-State: AD7BkJLltNMAPi8r4S1kD4EdpZE0bPGb+MBVDZvRS8sFncYiQNziAV1NbpGSrykmEbty6ZJd X-Received: by 10.194.21.197 with SMTP id x5mr4727872wje.90.1457627138664; Thu, 10 Mar 2016 08:25:38 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id da6sm4259289wjb.24.2016.03.10.08.25.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Mar 2016 08:25:37 -0800 (PST) From: Thomas Monjalon To: Tomasz Kulasek Date: Thu, 10 Mar 2016 17:23:55 +0100 Message-ID: <4053591.4SyQbLBBNH@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457607478-2184-2-git-send-email-tomaszx.kulasek@intel.com> References: <1456333729-3804-1-git-send-email-tomaszx.kulasek@intel.com> <1457607478-2184-1-git-send-email-tomaszx.kulasek@intel.com> <1457607478-2184-2-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add buffered tx api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 16:25:38 -0000 2016-03-10 11:57, Tomasz Kulasek: > +struct rte_eth_dev_tx_buffer { > + buffer_tx_error_fn callback; > + void *userdata; What about renaming this fields as - error_callback - error_userdata ? > + uint16_t size; /**< Size of buffer for buffered tx */ > + uint16_t length; Maybe a comment "Number of packets in the array" to be sure? > + struct rte_mbuf *pkts[]; A comment? "Pending packets to be sent on explicit flush or when full" ? [...] > +DPDK_16.04 { > + global: > + > + rte_eth_tx_buffer_drop_callback; > + rte_eth_tx_buffer_count_callback; > + rte_eth_tx_buffer_init; > + rte_eth_tx_buffer_set_err_callback; Please keep alphabetical order.