From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 473451B239 for ; Tue, 10 Oct 2017 23:25:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 88D7620CB5; Tue, 10 Oct 2017 17:25:39 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 10 Oct 2017 17:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=XnMw6l0YgZWU7BD Ejfx8h2wZhrIqmUhsfV9PShdeTB0=; b=RdeMzf3YmlAQFzhpCUZ/VHgJHVXJSjt UvIl9mtec9QtGLVVyH/I724QqPsG6BK0tIeM6me4QOr37uaaCEFgoBic2ZKXZOpt 0/rwzdjAQM/R/91hLFAxEwv8oW6IHQVgxOJM3tl+JUJ/NVaIHQe1U/QcVXEJq/By EnLCiDvK8bJQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=XnMw6l0YgZWU7BDEjfx8h2wZhrIqmUhsfV9PShdeTB0=; b=C0RnvIoS qnQj8t6wNWBVyppPkMia3I5ko1PEzI86/+IBOZAKOUv6Wef2p7hosBrDEIsnW0q2 k6Q838CmirMpeDO1Lj4W1z2CeHj3qEgGw8KQ01ad1QApYtljRGOy8iSLdbiYD5ma C9PY99a36QW9tJNHAwsUXtnY0+6nhLB2+JcqBHWbsGsZJF8/MLt6o85p4jad7+Sq dW8fGGNjue/4XuZON5RLgUHCAZR23m11V5PE9kFSj07zEHaBbHzItelNL+ou1bDX tmVbZ6dyNdzo6/Q+N5wPsyNWYcLf7xftcQaJ+wuP4y4a2wqWh2KkAFuxA8X5mF1s u0zWAY9wSuBAaw== X-ME-Sender: X-Sasl-enc: UObDA/DdXbkMnLeGlj2ae0pp+ledYtnX2E3T5jSzHSoZ 1507670739 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A6132418B; Tue, 10 Oct 2017 17:25:39 -0400 (EDT) From: Thomas Monjalon To: Tomasz Duszynski Cc: dev@dpdk.org, Ferruh Yigit , mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org, Jacek Siuda Date: Tue, 10 Oct 2017 23:25:38 +0200 Message-ID: <4053752.6hKTFdWHEG@xps> In-Reply-To: <20171005084333.GA20961@tdu> References: <1506594158-15721-2-git-send-email-tdu@semihalf.com> <20171005084333.GA20961@tdu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/mrvl: add mrvl net pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 21:25:40 -0000 05/10/2017 10:43, Tomasz Duszynski: > On Wed, Oct 04, 2017 at 05:59:11PM +0100, Ferruh Yigit wrote: > > On 10/4/2017 9:59 AM, Tomasz Duszynski wrote: > > > On Wed, Oct 04, 2017 at 01:24:27AM +0100, Ferruh Yigit wrote: > > >> On 10/3/2017 12:51 PM, Tomasz Duszynski wrote: > > >>> Add support for the Marvell PPv2 (Packet Processor v2) 1/10 Gbps adapter. > > >>> Driver is based on external, publicly available, light-weight Marvell > > >>> MUSDK library that provides access to network packet processor. [...] > > >>> +static struct rte_vdev_driver pmd_mrvl_drv = { > > >>> + .probe = rte_pmd_mrvl_probe, > > >>> + .remove = rte_pmd_mrvl_remove, > > >>> +}; > > >>> + > > >>> +RTE_PMD_REGISTER_VDEV(net_mrvl, pmd_mrvl_drv); > > >> > > >> Please help me understand. > > >> > > >> This driver implemented as virtual driver, because: > > >> With the help of custom kernel modules, musdk library already provides > > >> userspace datapath support. This PMD is an interface to musdk library. > > >> Is this correct? > > > That is right. Another reason this NIC is not PCI device. > > > > We support more bus now :). Out of curiosity, which bus is device on? > > Bus is called Aurora2. That's proprietary SoC interconnect fabric. So you should provide drivers/bus/aurora2/. It would do a software scan of devices (probably looking in sysfs). Then the probe function is nearly the same as with vdev init. It could provide a better user experience by removing the need of explicit declaration of devices. It will allow to be integrated in a more generic whitelist/blacklist mechanism. And having such well defined bus code and objects will probably help in your future developments.