From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f181.google.com (mail-wj0-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id 6A703377C for ; Mon, 5 Dec 2016 15:08:57 +0100 (CET) Received: by mail-wj0-f181.google.com with SMTP id v7so291372570wjy.2 for ; Mon, 05 Dec 2016 06:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=MfLyW5TdFcrQk+xe1aVKfJjg6nPZRdGx/SuUcWNyQK4=; b=bTutobxnJkUZx7riXbj9a6xTHP630oQecdqQw8pyNT429S+7PXstQxaFgHbhYAWwye 6ugqDpmvJvBs+v1WZtTuh5EEDa5w9X4gUKL5lQkxr66cSefHgWbNmbycyQ9X8fRqkm9T rAPdQzqRYOu4uAR/8rb8Sjof4u83TJjThS/w9ReyRdxz7pnhuskxDY1HG7wOnJBuco9+ D7qWitCHv0JISPCVpcl58GPuJYesrBlvzIn/d50Owl24bvM3QY5IEDZkFS0mE7HK2d4E PsUF4KTdW23NYDSJ0IEACOKqaIewjfRzd3ELjECQU6vbbizD0Plqf4kNJC9RfC24tEk9 /aWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=MfLyW5TdFcrQk+xe1aVKfJjg6nPZRdGx/SuUcWNyQK4=; b=iPdH2/7VgnMObmKkKvIUrl8ncOLUAtt07lpnvKm/86rTuVg4xxOts+D5ZhEvD62Yys Y4RTJ/RBq7YBtzwETHVYVjupvrL7avqSrUBsqm6/dLi8aHJY8TNDj6zzUdNC/RLXc1+G aGFI8irnBAlyaBEUs789MQGP1WWnh3+TBK1Eed2SdfRerRIY7LQ8zT+1mTuXPaQmUO6E h0owGaRt71M668m5+e4HpJ6b48Dkm5MaNWrsqPsFOTa20VZGXExJsHEf+7SeWWcwZOTY mmYUZ/iP6JguXRCJtTl/pwD+gh5qhpKk+9j3TkZAcrhs0DKXtymyRNVIGGOE6necHj/d kRmA== X-Gm-Message-State: AKaTC01MtCoep1KyesQPboNVbx2ubOmZY5Khqz4CSXqNMtUmZSAKgy/Zwpp5obhs/DFqHJsu X-Received: by 10.194.209.169 with SMTP id mn9mr48479480wjc.114.1480946937106; Mon, 05 Dec 2016 06:08:57 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 138sm291889wms.20.2016.12.05.06.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 06:08:56 -0800 (PST) From: Thomas Monjalon To: Olivier Matz Cc: david.marchand@6wind.com, dev@dpdk.org, keith.wiles@intel.com Date: Mon, 05 Dec 2016 15:08:55 +0100 Message-ID: <4058102.qjHpyqyoUp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1479915265-17547-1-git-send-email-olivier.matz@6wind.com> References: <1474011832-29987-1-git-send-email-olivier.matz@6wind.com> <1479915265-17547-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] log: do not drop debug logs at compile time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 14:08:57 -0000 2016-11-23 16:34, Olivier Matz: > Today, all logs whose level is lower than INFO are dropped at > compile-time. This prevents from enabling debug logs at runtime using > --log-level=8. > > The rationale was to remove debug logs from the data path at > compile-time, avoiding a test at run-time. > > This patch changes the behavior of RTE_LOG() to avoid the compile-time > optimization, and introduces the RTE_LOG_DP() macro that has the same > behavior than the previous RTE_LOG(), for the rare cases where debug > logs are in the data path. > > So it is now possible to enable debug logs at run-time by just > specifying --log-level=8. Some drivers still have special compile-time > options to enable more debug log. Maintainers may consider to > remove/reduce them. > > Signed-off-by: Olivier Matz Applied, thanks