From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C3305316B for ; Thu, 23 Feb 2017 15:30:35 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2017 06:30:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,198,1484035200"; d="scan'208";a="68735144" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga005.fm.intel.com with ESMTP; 23 Feb 2017 06:30:33 -0800 To: Shijith Thotton , dev@dpdk.org References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com> <1487669225-30091-17-git-send-email-shijith.thotton@caviumnetworks.com> Cc: Jerin Jacob , Derek Chickles , Venkat Koppula , Mallesham Jatharakonda From: Ferruh Yigit Message-ID: <405b6b63-da27-98d5-761f-b56158b4f637@intel.com> Date: Thu, 23 Feb 2017 14:30:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487669225-30091-17-git-send-email-shijith.thotton@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 16/50] net/liquidio: add APIs to allocate and free IQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 14:30:36 -0000 On 2/21/2017 9:26 AM, Shijith Thotton wrote: > Add APIs to allocate and free instruction queue. Allocates instruction > queue 0 initially to send device configurations commands and later re- > allocates as per application requirement during tx queue setup. Can you please describe the relevant entity briefly in commit log, even one sentences is enough. For this patch: What is Instruction Queue (IQ) For patch 18/50: What is "soft command pool" ? etc... > > Signed-off-by: Shijith Thotton > Signed-off-by: Jerin Jacob > Signed-off-by: Derek Chickles > Signed-off-by: Venkat Koppula > Signed-off-by: Mallesham Jatharakonda > --- <...>