From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 695015F13 for ; Mon, 28 Jan 2019 15:52:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 074FE22336; Mon, 28 Jan 2019 09:52:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Jan 2019 09:52:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ajg9F5Ly9RnkqILx9oDgVWEH4tNyOUhTjBKOfS+4WHg=; b=Ueb0wIml0fQP VtGumQtnfcHNVMI1iTq9HYqQePVwSR4bntRZuM73b9dukVsoP3PGsN9n+beCco8D cMceINgY/xcBmhjCgZ+0rgwGMVWyRHH/aDLbEzM54/vf/nGLWh8BkXV04eIWxp2+ Uv72YKS5r8jvSTXB8NbVLlfnUnw5Qns= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ajg9F5Ly9RnkqILx9oDgVWEH4tNyOUhTjBKOfS+4W Hg=; b=ovv/Z+9J+YL5LOcqKj1Fgf1kefBf41Um3j7O/sJvP5t9/i2r5H0PNOBEJ gHiyngxecZuoFOCYAnL/mQI8MhiokYv76ERLJsVRqOmqpQ+7a3hAeqerA2glYDKI 9YmSPgljigns+lLHwwikgAdqbIEH75rvNQlYagL24cBTOk15Ki/+pLXhh0KheSy2 qDvASOmcUx7uYa6iGaImPtPGxsqfrT9ymf/+J+oWIVMfPJnIKEpQQ+EROFbj4m9b nmF7tcUh2uxL2Zc1myox9L/P76MfPsV3dcXSvbmb1RL7MMJzcLbyiuZX9EtK+hcX ShnRAk4KLC9IY4gx6XaehkBVnxwJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjedtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 70F2F100E4; Mon, 28 Jan 2019 09:52:35 -0500 (EST) From: Thomas Monjalon To: "Varghese, Vipin" Cc: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Yigit, Ferruh" , "Padubidri, Sanjay A" , "Patel, Amol" Date: Mon, 28 Jan 2019 15:52:34 +0100 Message-ID: <4064656.Pp56jkNFLl@xps> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com> References: <20181030141847.23861-1-vipin.varghese@intel.com> <1830265.56Hsnbp04L@xps> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 14:52:37 -0000 28/01/2019 15:27, Varghese, Vipin: > Hi Thomas, > > snipped > > > +Compilation of patches is to be tested with ``test-meson-builds.sh`` > > > +script in ``devtools`` directory of the DPDK repo:: > > > > Would be more straight-forward to give the full path: > > devtools/test-meson-builds.sh > I also like to use ' devtools/test-meson-builds.sh', but based I followed the formatting used for 'test-build.sh'. > > Which is ``` Compilation of patches and changes should be tested using the test-build.sh script in the devtools directory of the DPDK repo```. > > > No need to add "DPDK repo". > > > > > + > > > + devtools/test-meson-builds.sh > > > > Do we really need to repeat the script name here? > Same as above. > > Note: please let me know if you still require the change for above items? Yes I've seen it was like that for make test. Given the meson test script has no argument, it's better to make it simple and just give the full path. > > > +The script internally checks for dependencies and tool chain. Then > > > +builds with > > > > tool chain -> toolchain > I will fix this and share the updated version. > > > > +shared and static libraries for Linux and BSD targets. > > > > Why "Linux and BSD" ? It is just testing for the running OS. > The default execution generates for default targets as ' build-gcc-shared, build-gcc-static & build-x86-default'. If cross build is supported ' build-clang-shared & build-clang-static'. > > As per my understanding this will true for Linux and BSD (Windows I am not aware). Hence I mention it as 'Linux and BSD'. > > Note: > 1. If it is with regard to wording I can reword from ' Then builds with shared and static libraries for Linux and BSD targets' to 'Then binaries are built with static and shared library for default and arm cross build on Linux and BSD' > 2.if support & built infrastructure works for Windows I can reword from ' Then builds with shared and static libraries for Linux and BSD targets' to 'Then binaries are built with static and shared library for default and arm cross build for Host OS' > > Please let me know is 1 or 2 is right one? We must avoid giving too much details because it will be outdated quickly when updating the script. Please keep it simple and don't mention Linux/BSD or Arm. You can just explain the intent: it is testing several combinations of compilation configurations.