From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 964FDC3C0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 14:31:56 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so132011707wiw.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 05:31:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=DD3pWgrBc7v9hwuAHTnqoNAUyXj1M3wVq61Msh5D3FI=;
 b=V2zMIYnZaOval9X1DlRDXD9Olguri65JVI7vvSiSA5jqbifV1Zhp08L+UA37Glbvt5
 HE0WUNL3g8tnGOksa0r/PVeJajRy8QR8vzLpiJLCuFfY5YDa3upZ8Ygt3AoAgNmcyejv
 D9Zo9cmeolfPA5uRFo46i505dvH0/E3A8wtOv8S8JfSRqGb7NNBewEZIVnxigmqCxSYq
 7OZINvGUq35fQe982KexAT9tdiXNe7RaXgbR/Dn5wopJFgTyd5EF0w57HGWxLWm/U8/a
 AOfQTXshnmU6MJ+oNR+D0C26Vtt7U2uaO6XGnwTtiPdpFgRMVpNTNi52HpmlZAnE8cUD
 6xXQ==
X-Gm-Message-State: ALoCoQk/b2pfcbLf+pgRrSIv09xnmoslv4hF4UrIFZde+jiUtCp/vWUzjlF1Yj/c7kA5lm3rfBZV
X-Received: by 10.180.37.178 with SMTP id z18mr30360264wij.9.1434544316457;
 Wed, 17 Jun 2015 05:31:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id mv11sm25780391wic.23.2015.06.17.05.31.54
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 Jun 2015 05:31:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Wed, 17 Jun 2015 14:30:55 +0200
Message-ID: <4065601.TTgiMRsfyC@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <2e5139b0b03cdd49ad41feb8d3747d6d10f35255.1433164517.git.rahul.lakkireddy@chelsio.com>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <cover.1433164517.git.rahul.lakkireddy@chelsio.com>
 <2e5139b0b03cdd49ad41feb8d3747d6d10f35255.1433164517.git.rahul.lakkireddy@chelsio.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v2 02/11] cxgbe: add cxgbe poll mode driver.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 12:31:56 -0000

It doesn't build as a shared library.
Please add EXPORT_MAP and LIBABIVER to the Makefile.
It would be easier to test if build config was merged in this patch,
with the Makefile.

Please merge also the maintainer infos.

2015-06-01 23:00, Rahul Lakkireddy:
> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))

RTE_DIM may be used