From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CBB021B47E for ; Mon, 6 Aug 2018 11:51:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6830F21C93; Mon, 6 Aug 2018 05:51:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 06 Aug 2018 05:51:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=N0EykJcUtXOLLSxsZ970I0U+V+ Nc1/aE9868Y/LnDFQ=; b=oDRGn+mlVIlXqDob/zHcpEU2V6YjjHKTCHNYr0REn1 guChFhS12eSqlPXvMwSNClrm8Z+NZqStKiahQF6X9Dy0+0s2/mZDSCic31/9ZO9r uX2TkSMybhw1yzdxZKRwOswzWGy5seRfl11cjuIN8vBY8nXZUxWxcEpqtY5hGHZk Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=N0EykJ cUtXOLLSxsZ970I0U+V+Nc1/aE9868Y/LnDFQ=; b=PtdhiYjYsXcH84km4Sg4iU P5IkdVoVmYnRhnFpuBnR0Ck16/C7Ti8o7bwOJ1OGljE2QZd4V9Fkecifst8ggpnJ BMCltwFetcqpr7LoFUtGKL00I59mxuJdMdlI1ASX0EobG8js7d0QrEZ9WkOTZePC zfiot7PkP6eoMGjTpr4PkAtbnwNBiyUiEHhGATilA9xDzxqx79oDsD0Ct/nvmADk nI+p2t4b+Wnyl9vYcITVGA9ufoL4sDKBKdxDzjZRAsKWbG6YT5eQNGSi3kz5D42j MaIxtgUjz3Ydqn8RHN6jGJ137o0t74VJ4qR3zLlQzfuXXoCCKACP/Z/MJJ4jbAqw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (158.82.136.77.rev.sfr.net [77.136.82.158]) by mail.messagingengine.com (Postfix) with ESMTPA id 1B059E48AB; Mon, 6 Aug 2018 05:50:59 -0400 (EDT) From: Thomas Monjalon To: anatoly.burakov@intel.com, chaozhu@linux.vnet.ibm.com Cc: dev@dpdk.org, Takeshi Yoshimura , Takeshi Yoshimura Date: Mon, 06 Aug 2018 11:50:56 +0200 Message-ID: <4068541.lKVHRX04u0@xps> In-Reply-To: <20180806084309.5489-1-tyos@jp.ibm.com> References: <20180806084309.5489-1-tyos@jp.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 09:51:03 -0000 06/08/2018 10:43, Takeshi Yoshimura: > Commit 73a639085938 ("vfio: allow to map other memory regions") > introduced a bug in sPAPR IOMMU mapping. The commit removed necessary > ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, vfio_spapr_map_walk > should call vfio_spapr_dma_do_map instead of vfio_spapr_dma_mem_map. This is fixing an old patch: http://git.dpdk.org/dpdk/commit/?id=73a639085938 > Fixes: 73a639085938 ("vfio: allow to map other memory regions") You probably want it to be backported in previous release, so you need to add Cc: stable@dpdk.org > Signed-off-by: Takeshi Yoshimura It is common to have bugs in sPAPR implementation. How can we be sure this one is OK? Should it be added in last minute of 18.08? Or can it wait 18.11? Adding Anatoly and Chao who are maintainers to decide.