From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2A77A0C46; Mon, 27 Sep 2021 20:34:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B40B410DD; Mon, 27 Sep 2021 20:34:27 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7B71C410DC; Mon, 27 Sep 2021 20:34:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="224573014" X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208,217";a="224573014" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 11:34:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208,217";a="537796916" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 27 Sep 2021 11:34:23 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 11:34:23 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 11:34:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 11:34:23 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 11:34:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HV5ukV0DTf99Eh6uTXt8uX/cmqx3jmd5WbX4E6ZZ98Cdi+KYvcQ1eTRzAf8/q62D7EnPrS/uDcQVxN8Z6fJic8y0efplC/EmUmJRjQf2ENznlKQXEaWH3Ww8v63ub+/JqHm894JK9lxmVNszi/7nkHM9j9aPKlHgM0sB5HlUe3K6rjfbgJXyXOrZwItFa/TlPhuc036Hwok5xlCoRJib/BN7pcx1AOucwl2Topt7M95qviDfDPwpG3LoPuLCfdQWgG2Ql/VnPokpj9vX2j2b2LNufkrYiILZHx5AruxsHHcoF45nU+Bib78OJkLROA4b/CVrPwMKS3cBTab8zIb9FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pVNOuRUI36o6HN+iPjFXTU/1HfvFWY131dWROHU9DWQ=; b=fzqvfD6DMioVcY2J9WvwtHd3eCfVfpsFZi5HRz8iUEJaX9wCRl1c5EnC7AtUEJZjWoW0/V/gdhHZZP5h4xrNumPHJnb8SxGcVlHD9kIQZ4uxAR2zWk3XMIGVDP+jynvzbj/+Cn69fVAz9h2HmxVdgU8LUDJxZaZHHUho77cF0qy96Px+cHy9D051Xxxg8elbmahLlPcy5pHqMJKvocNXGDFIj7EXypPk4Bvyt3P0ZFQZpTdrl8OoBv8EuA7laSzdQ0AYQuzsDZWtgzGLVw/uY6a+e0izSslgXM9h0YEMw56Dr6SO/Wq55jvdi3fSAxP3Q8rNApu+axHHqaC0ZJrTyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVNOuRUI36o6HN+iPjFXTU/1HfvFWY131dWROHU9DWQ=; b=p0RQjc4acWZGm/C6ojjIFTp5aRYD/mY5yxlIuKhNFsBhGD64Xv+DKmpRZwYiV36Bbg73+7YuL7ONfa5vcIXwzmsBogt9yx77NkJ2IwBGDrfgILPION7IrgISsrN8nSSAV5D1RiYPoznFve0sq49mU4CwGF1bEenL8dPA6kQUprw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SA2PR11MB5130.namprd11.prod.outlook.com (2603:10b6:806:11d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Mon, 27 Sep 2021 18:34:21 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e%6]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 18:34:21 +0000 To: Pallavi Kadam , CC: , , , , , References: <20210927184322.1455-1-pallavi.kadam@intel.com> From: "Menon, Ranjit" Message-ID: <406cbb21-2abb-b6f5-1d8a-3e61a6460d84@intel.com> Date: Mon, 27 Sep 2021 11:34:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <20210927184322.1455-1-pallavi.kadam@intel.com> Content-Language: en-US X-ClientProxiedBy: MWHPR1701CA0021.namprd17.prod.outlook.com (2603:10b6:301:14::31) To SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) MIME-Version: 1.0 Received: from [192.168.254.28] (50.39.109.205) by MWHPR1701CA0021.namprd17.prod.outlook.com (2603:10b6:301:14::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14 via Frontend Transport; Mon, 27 Sep 2021 18:34:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f4351a7-35a7-4404-e7b6-08d981e56bc6 X-MS-TrafficTypeDiagnostic: SA2PR11MB5130: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RqclqVKZ5P3It0jC6MwQ8n6tsUI4gyn3EKH/FvGu1TDplaQof1t3NJOwJmEUGX5se6P8pZfs+SnN8Cn1r8aVeMCXmc5YZPmbTl3Moac3AWWKN/455hOPK1sIOJm+WPsondEevYjOkVmfZdhXEV6WbEq1kPleaAsS1CFkrVsNCvOZUmQjMg0dBV+gZQQg3Nv++K6g/YD8McjG6mEDynmvMO7RbFU5PRIn32DyjNbAXJyrsMaTtssmvbv+SORcUHzW5ZcFwcEKjmGZ9E8mbtvMNWOgbLUi9W9/LeGdjB3NuqLNRw6fboevb189nmNsZWE4OPVqbCRMSRkj4OUF3fofABaB5gJi1Nad3P7s4UYbDxY+unpc+ek/vBu9d4K+gWLe1zQ5HSglH/A+Fm0V+jc1aaTi8FW7q3tSm2x7ftV3oV8PJQ38T3+cT2lsWHWUfbwjo6VWNZoCWw47SHAYAWjIzOnHPI4YCOleJNvMx5k1CkxQvUKc4PYT59pBCdAjdXNd6Uxim+r09Qw+XRjuXXvqclihFcS/X6ZiPp/NqXNWWRHFyFhWk2wHz3T6nA0MqciKNF/I69TbvSk8qdbFGDJvaW16JhwAENih+6uJdOkHj+2Z/s14b+7NJKh3XpD8VmRB3YUi+N0+4yZ4pb5nd3VrgTS9SIMNLW1bOclBFC4NyInSXJ4EYnlLYso4nh4HYGa4Fsy8nkIGTFcXNoaydSk9twltwsDHTSJ6SeKJUlWAxdixCIe4ZnTAXOkn/qDRnz6l X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(8676002)(66476007)(107886003)(31686004)(66556008)(33964004)(66946007)(8936002)(45080400002)(26005)(6486002)(186003)(956004)(83380400001)(38100700002)(2616005)(16576012)(508600001)(2906002)(31696002)(36756003)(5660300002)(86362001)(4326008)(316002)(45980500001)(43740500002)(579004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blNwaHh3bUhwVTJPbEF4ZmxsOUNqVGg0dGYvSzlJYUtBYm83TXZOZG9oejI2?= =?utf-8?B?aG1Rdm11ZkMwVWtSYzZudFVMKzA5RWdBRTQ3d01QMy9HN3VibTRxRVZsT3Ey?= =?utf-8?B?VmZnRGZCcFhHUTZyWExoU1NzOFNKM0laL09pWFlXMDhVeTNwZE51dGhqZlp0?= =?utf-8?B?cmg1UHJoUVZJNi9EVmFKOHhoUEg2dFE2b1dPMEdpM3pkS05hTy9ncVpVU2J0?= =?utf-8?B?TW9VQVp0bzhwd3RraDZlcC8yZk55UEx0UW10NForVGRzVUtoS2hON0h6OVh1?= =?utf-8?B?MTBkVVB3YXNSblBpaFVlV2FYdWhPVFB2RlJXWHBZanFHS3VxT3lQVjZSaENB?= =?utf-8?B?M0NoS3kzUktGT1hNcEo4STNGdUZ0NTFvSEp0bzQ0Rml3UjEvZWFuWDI5MVAy?= =?utf-8?B?d2p3Z09ZME9DZjlwa1dqYXpDVlZlZzlYRm9PUFhIMjIwRW1DRFE1SEJzOUFu?= =?utf-8?B?QWErcmNjbW9iZDIyeTIvaGdmcnNRYVd4TE52WTRkYkRFQ05pV2VZS1NEeXVE?= =?utf-8?B?MHV1UWQ1NndRSys2eWdTcFZwWnVYRDd3c3RLdkJLM24xS3RCUTZqOTEwUTJM?= =?utf-8?B?L1A5K3Rpc1M5dTdPRWxmdlcyODQvSCt0WURKT3ExZEk1REcrMlJkSlJpR1hx?= =?utf-8?B?Q3k1elBVSlVUdnJPNDEvTFdOSC85OHkzRWp6SzdOSVZTQmlNRmJ5YjVoN1hI?= =?utf-8?B?ZWFEVG9oSVNCMUhhSTFqdFA0VFV5bHFaaFVNbzc4NXMyQU1ZYzBIQ2ZTUXB5?= =?utf-8?B?QStyektheWw4aDFub256SzM3elpEYW9CU090WGQxc2xKWnV1SEg4SjMxYlJQ?= =?utf-8?B?UHlINk1IVTlQYW9tRVlVMENMbmhVKzdwUVlFNW5ZQlBrb2pCVmdBRzNodHdW?= =?utf-8?B?MWJ1V0xrZmlaUHV5K0d6MEZLTDE1Y3RXeU5tbGo3NDhaRWdZYWxDeFVwd2hB?= =?utf-8?B?cmtHcFNNNHBRQU1PTXFwSFhhQmFVK0dqNnBGVFozNm1WYnlKM0dQb0FSc0hN?= =?utf-8?B?MnhMZkV0amREZmVmRmhYT21iamtIQ2JJQmZ1M1RPYWdkRkZNLzJOZklPMVNX?= =?utf-8?B?Q0ZydXZTY0FxMSt2cnZGTyt5WDJ4Q2cyY2NrM2crd0FSeERJMER0SFFsY3V1?= =?utf-8?B?MEdXT2lwU2VZN1NuOUg3UmpEZjBia0ZweU1kMy9Sc3diYTNDa2d5enVLTW54?= =?utf-8?B?QzVkRDlDVytqQVVsYUl1amRUZWJFK2syZURiRndGVm1NZDRtNlhjcnBacXpO?= =?utf-8?B?bm54OFNaandMMUwvNUtLTnJaaFJ5WmNtdjhSMnFzVGZRSjVMTWRkYVZHTUdh?= =?utf-8?B?L1BHN3dDc3l0Q3o2MmsxUm91VDZqa1dHRTR4TEhqK0txSTdONElFbk0rRXg0?= =?utf-8?B?aUl3amNkREFPWkppNDM1U0djQmFnajZneGZNWjFJSXU2THMvejRmTzB6Q3dV?= =?utf-8?B?NEw1cDYvb3pTR05EeU9NRTVhN0wrSVI3OEt3VUxnU1Z4d2ZxLzZCUXZwVmpD?= =?utf-8?B?R1F0UDJ6UTAvdGJTY3lxMi9wNURHTlpGSWhoRzMxMWZuNnlPM1l1MU05eGU0?= =?utf-8?B?TTltK3B2THRPMmxlUmMwaWZSYi8rWThWVjhTalR5ZnlITHFJRFRHdFkvcTRq?= =?utf-8?B?Vk9vYnZ4dlgzV1Z6eHluekFMdVllSys4b2pZdDNDM3V6dE81TzhlZnVuR0lJ?= =?utf-8?B?bVp2YmpzekdlWVNGUkhZYk5pL0JPa0lVcEhSVEdwdUJXK2IrOW9iQ2NKNEo0?= =?utf-8?Q?R7fIRCzm+bO6KvbnHV0kmf+X/Ibrxq8SXmZkTgx?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5f4351a7-35a7-4404-e7b6-08d981e56bc6 X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 18:34:20.7398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +344prbL1arMrb2zFv7LmuTKLDc+G2C+O84uqv0m4nL98WS+U7Ei2thu5HL9jfxYqZ+Fx+740CkCLXT+i6Ukdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5130 X-OriginatorOrg: intel.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix unknown NUMA node value on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" (Sending the ACK again since Outlook appeared to make the email address a smart link!) On 9/27/2021 11:43 AM, Pallavi Kadam wrote: > Based on the rte_eth_dev_socket_id() documentation, > set the default numa_node to -1. When the API is unsuccessful, > set numa_node to 0. > This change more correctly resembles the Linux code. > > Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows") > Cc: stable@dpdk.org > > Reported-by: Vipin Varghese > Signed-off-by: Pallavi Kadam > --- > drivers/bus/pci/windows/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c > index 343ef6f33b..644c452c76 100644 > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers/bus/pci/windows/pci.c > @@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info, > } > > /* Get NUMA node using DEVPKEY_Device_Numa_Node */ > + dev->device.numa_node = SOCKET_ID_ANY; > res = SetupDiGetDevicePropertyW(dev_info, dev_info_data, > &DEVPKEY_Device_Numa_Node, &property_type, > (BYTE *)&numa_node, sizeof(numa_node), NULL, 0); > @@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info, > DWORD error = GetLastError(); > if (error == ERROR_NOT_FOUND) { > /* On older CPUs, NUMA is not bound to PCIe locality. */ > - dev->device.numa_node = SOCKET_ID_ANY; > + dev->device.numa_node = 0; > return ERROR_SUCCESS; > } > RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW" Acked-by: Ranjit Menon