From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2C5FA00C5; Sun, 5 Jul 2020 10:38:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DA3A1D952; Sun, 5 Jul 2020 10:38:04 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 8BD021D944 for ; Sun, 5 Jul 2020 10:38:02 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 9E339580177; Sun, 5 Jul 2020 04:38:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 04:38:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 76CVIHLutgHxQJaC+/PhiqJ2qiJI7K3SzHAoqRP95GY=; b=O/wfR+kw3e0ykqX1 1s7O9/xxDUPX7kwLXMhqylVTsZEyGn0segap2PfNlhsXXcFI0NZqzrcMkkfgPPWX 1+SCLxDLhkM8XLhYxF7I1sHrIlBgXQF1q/VAc/BlyAdnA9645CwWA+8crcq0S2NE qBPyeRsOs336swWkm/nrnET/Dh4qz2MOD1CBBzb8FhRYZuzX1JUrsEc8yl2+RAaT RRCulWoJ1Pff9AsTpdQL2tx3D9mW3WvOHc2oEYlAyl504wxeI9rrhC1kU24mkSSA HeHhoZ46t4lqY24iJZXE8G030AYIbH7mIYtMlbmUNEvpD/tzanenKigjddGx4EV2 WUjmhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=76CVIHLutgHxQJaC+/PhiqJ2qiJI7K3SzHAoqRP95 GY=; b=ktwOAI3OSHTJ4+PaLNHGdrz00wMP5fFMvT06u2KR9zYSdoOFQ8/a2p6E4 DUuz8EKv4KHA34tkk5hjtKgX9Y8fBpWNRvhHabTEy0C1ygRjNh8vXaf8m6lL+lle HvOw0K20JflACjd4a6yCmCXcHb+itzevJMZ6/LQxIsXjffpTKf9ZwXlJWs/Klo0P w0moLa6s0vv049m7KaxJ8AYLqXQEY9jxoPqgmNZj9J/+FmmWXGF2U0zl7powdhwb GQ8J5On7MmALHakmXy2rFloE/l6gD+qA+0i4Bt69B0r1fguT4qqujyHXszUbKWAr hVAO6g4XSK4i+OjM3ziwqqGWsQ1Vw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeeileekuddvkeehtdeivddufeevfeegveffheejfefhtddttdejhfel gedtleegtdenucffohhmrghinhepmhgvshhonhdrsghuihhlugenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 541AE328005E; Sun, 5 Jul 2020 04:37:58 -0400 (EDT) From: Thomas Monjalon To: "Kinsella, Ray" , Fady Bader Cc: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "nhorman@tuxdriver.com" Date: Sun, 05 Jul 2020 10:37:56 +0200 Message-ID: <4076841.gji8TSPR8A@thomas> In-Reply-To: References: <'20200531124151.16848-2-fady@mellanox.com'> <67f92962-1cc1-cdbc-0371-a57a5b38533d@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2020 09:00, Fady Bader: > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > On 22/06/2020 12:55, Fady Bader wrote: > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > >> @@ -11,6 +11,10 @@ > > >> #error Use of function versioning disabled, is "use_function_versioning=true" > > in meson.build? > > > Do we need a meson error/rule that catches if people explicitly try to enable > > function_versioning. > > > We don't want to just silently fail under such circumstances? > > > > > > Would something in lib/meson.build would work better? > > > > > > if use_function_versioning and target_machine.system == "Windows" > > > // complain loudly ... > > > endif > > > > > I think this would be a better approach. > But instead of checking if the use of function versioning is enabled under Windows > and then complain, I think we should simply disable it from Windows in the > meson.build file. Something like this: > > if target_machine.system == "Windows" > use_function_versioning = false > endif Did you try? If you disable function versioning, compilation will fail with the #error message above, right?