From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A9CBF6CC1 for ; Tue, 11 Oct 2016 14:47:35 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E65957F7AD; Tue, 11 Oct 2016 12:47:34 +0000 (UTC) Received: from [10.36.4.94] (vpn1-4-94.ams2.redhat.com [10.36.4.94]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9BClUYE015657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2016 08:47:32 -0400 To: Olivier Matz , dev@dpdk.org, yuanhan.liu@linux.intel.com References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-3-git-send-email-olivier.matz@6wind.com> Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com From: Maxime Coquelin Message-ID: <4076968f-d787-4ca2-bd07-43e219ff8f6b@redhat.com> Date: Tue, 11 Oct 2016 14:47:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475485223-30566-3-git-send-email-olivier.matz@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 11 Oct 2016 12:47:35 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 02/12] virtio: setup and start cq in configure callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 12:47:36 -0000 On 10/03/2016 11:00 AM, Olivier Matz wrote: > Move the configuration of control queue in the configure callback. > This is needed by next commit, which introduces the reinitialization > of the device in the configure callback to change the feature flags. > Therefore, the control queue will have to be restarted at the same > place. > > As virtio_dev_cq_queue_setup() is called from a place where > config->max_virtqueue_pairs is not available, we need to store this in > the private structure. It replaces max_rx_queues and max_tx_queues which > have the same value. The log showing the value of max_rx_queues and > max_tx_queues is also removed since config->max_virtqueue_pairs is > already displayed above. > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 43 +++++++++++++++++++------------------- > drivers/net/virtio/virtio_ethdev.h | 4 ++-- > drivers/net/virtio/virtio_pci.h | 3 +-- > 3 files changed, 24 insertions(+), 26 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime