From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 081B75F3B for ; Fri, 8 Jun 2018 15:58:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 816BA859AE; Fri, 8 Jun 2018 13:58:06 +0000 (UTC) Received: from [10.36.112.47] (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D55622026DEF; Fri, 8 Jun 2018 13:58:05 +0000 (UTC) To: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com References: <20180529094514.23835-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <407773c9-8653-a35b-d531-475b2491bff4@redhat.com> Date: Fri, 8 Jun 2018 15:58:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180529094514.23835-1-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 08 Jun 2018 13:58:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 08 Jun 2018 13:58:06 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 0/2] Vhost: unitfy receive paths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 13:58:07 -0000 On 05/29/2018 11:45 AM, Maxime Coquelin wrote: > Hi, > > This second version fixes the feature bit check in > rxvq_is_mergeable(), and remove "mergeable" from rx funcs > names. No difference is seen in the benchmarks > > This series is preliminary work to ease the integration of > packed ring layout support. But even without packed ring > layout, the result is positive. > > First patch unify both paths, and second one is a small > optimization to avoid copying batch_copy_nb_elems VQ field > to/from the stack. > > With the series applied, I get modest performance gain for > both mergeable and non-mergeable casesi (, and the gain of > about 300 LoC is non negligible maintenance-wise. > > Rx-mrg=off benchmarks: > > +------------+-------+-------------+-------------+----------+ > | Run | PVP | Guest->Host | Host->Guest | Loopback | > +------------+-------+-------------+-------------+----------+ > | v18.05-rc5 | 14.47 | 16.64 | 17.57 | 13.15 | > | + series | 14.87 | 16.86 | 17.70 | 13.30 | > +------------+-------+-------------+-------------+----------+ > > Rx-mrg=on benchmarks: > > +------------+------+-------------+-------------+----------+ > | Run | PVP | Guest->Host | Host->Guest | Loopback | > +------------+------+-------------+-------------+----------+ > | v18.05-rc5 | 9.38 | 13.78 | 16.70 | 12.79 | > | + series | 9.38 | 13.80 | 17.49 | 13.36 | > +------------+------+-------------+-------------+----------+ > > Note: Even without my series, the guest->host benchmark with > mergeable buffers enabled looks suspicious as it should in > theory be alsmost identical as when Rx mergeable buffers are > disabled. To be investigated... > > Maxime Coquelin (2): > vhost: unify Rx mergeable and non-mergeable paths > vhost: improve batched copies performance > > lib/librte_vhost/virtio_net.c | 376 +++++------------------------------------- > 1 file changed, 37 insertions(+), 339 deletions(-) > Applied to dpdk-next-virtio. Maxime