[dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release notes

[dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release notes

[Fiona Trahe]

Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/release_16_11.rst | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 365b5a3..5f925b5 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -213,7 +213,18 @@ Known Issues
   Therefore, in order to use L3fwd-power, vector mode should be disabled
   from the config file.
 
-
+* **Digest address must be supplied for crypto auth operation on QAT PMD.**
+
+  The cryptodev API specifies that if the rte_crypto_sym_op.digest.data field,
+  and by inference the digest.phys_addr field which points to the same location,
+  is not set for an auth operation the driver is to understand that the digest
+  result is located immediately following the region over which the digest is
+  computed. The QAT PMD doesn't correctly handle this case and reads and writes
+  to an incorrect location. 
+  
+  Callers can workaround this by always supplying the digest virtual and
+  physical address fields in the rte_crypto_sym_op for an auth operation.
+   
 API Changes
 -----------
 
-- 
2.5.0

Re: [dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release notes

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Thursday, November 10, 2016 4:47 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release
> notes
> 
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release notes

[Trahe, Fiona]

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, November 10, 2016 4:47 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>
> Subject: [PATCH] doc: add known issue on QAT PMD into release notes
> 
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Self-nack 
Checkpatch white space errors - will send an update shortly

[dpdk-dev] [PATCH v2] doc: add known issue on QAT PMD into release notes

[Fiona Trahe]

Issue is with the digest appended feature on QAT PMD.
A workaround is also documented.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
v2
 - fixed trailing whitespace checkpatch errors

 doc/guides/rel_notes/release_16_11.rst | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 365b5a3..5f925b5 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -213,7 +213,18 @@ Known Issues
   Therefore, in order to use L3fwd-power, vector mode should be disabled
   from the config file.
 
-
+* **Digest address must be supplied for crypto auth operation on QAT PMD.**
+
+  The cryptodev API specifies that if the rte_crypto_sym_op.digest.data field,
+  and by inference the digest.phys_addr field which points to the same location,
+  is not set for an auth operation the driver is to understand that the digest
+  result is located immediately following the region over which the digest is
+  computed. The QAT PMD doesn't correctly handle this case and reads and writes
+  to an incorrect location.
+
+  Callers can workaround this by always supplying the digest virtual and
+  physical address fields in the rte_crypto_sym_op for an auth operation.
+
 API Changes
 -----------
 
-- 
2.5.0

Re: [dpdk-dev] [PATCH v2] doc: add known issue on QAT PMD into release notes

[John Griffin]

On 10/11/16 17:27, Fiona Trahe wrote:
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
> v2
>   - fixed trailing whitespace checkpatch errors
>
Acked-by: John Griffin <john.griffin@intel.com>

Re: [dpdk-dev] [PATCH v2] doc: add known issue on QAT PMD into release notes

[Thomas Monjalon]

> > Issue is with the digest appended feature on QAT PMD.
> > A workaround is also documented.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> Acked-by: John Griffin <john.griffin@intel.com>

Applied, thanks