From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A1A4A0555; Wed, 25 May 2022 17:40:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C44640146; Wed, 25 May 2022 17:40:35 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id EAA24400EF; Wed, 25 May 2022 17:40:33 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 333BC320097D; Wed, 25 May 2022 11:40:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 25 May 2022 11:40:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653493231; x= 1653579631; bh=WpL2VAacZFBClKQyCqz/ixNyzLOkjSIoyLh3l3jfWjo=; b=a vb6V1pHX3WjWBVyYC6+qUjEg8af94hRRdyKOMErffDkC5zISE921cKilFvdpv54O LqhhaUrHv44f2MECdyvTmLxqhTvotnjq4Yx3COrsct7NGWnn9ayxOcWEOHyf7WiF X5aSQRPDUfbvzDDNATf2QpxIMPmuwVovvyiBpFpC2Rmv8mnImuZUIpckXgMtI4fU jd2uz+hi8jhDDbDhTmT/WpRyvmh5hi6uOlYpKveNl9+DLJ4P6YcGTFzVGMyy3qsS QMLmSyggDMO9fSeK5sXw85MbsD31jbzB9K9r4NUhpLZYTudau7jvYlQ/iXZ/xlcD HkiStlfJLchYXs0gbHCyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653493231; x= 1653579631; bh=WpL2VAacZFBClKQyCqz/ixNyzLOkjSIoyLh3l3jfWjo=; b=K G1n0L3ulm+HeTxIOAhE8TacPyAXp9+BNQ+oZMYfcv3RGheq5BGshI7sei/M4bXTf 2pAdcuoGsCLrZeD4EkPOklrhubTWYUV20oq+novKQPpKggv4j+Nk0otJAJJsFf0Z mOPoh1lvakThyGr7BZYbFCWIFKi6zg1UPE0J7lFWVZrlIUK2fz9n8jkSwByr5cYd AAJZ18neKrzik4tyX4NWmMWa6fiHevGd2WX1yVCv1FzRK0LaZ2tF+D7OzJ0PdKzF VwLYxqbKKZOm9D4jf2dk9fFgEtY76qmUQd6kfMakPbgUaXTdLqpa14be1WvxRYoG Tk5rCXe+frR2LASYrREMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeehgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvd elteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 11:40:29 -0400 (EDT) From: Thomas Monjalon To: Ray Kinsella Cc: dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org, David Christensen Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector Date: Wed, 25 May 2022 17:40:12 +0200 Message-ID: <4084096.uADA5c2rLh@thomas> In-Reply-To: <87ee0hzvd6.fsf@mdr78.vserver.site> References: <20220525095307.675312-1-thomas@monjalon.net> <87ee0hzvd6.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/05/2022 13:48, Ray Kinsella: > > Thomas Monjalon writes: > > > The AltiVec header file is defining "vector", except in C++ build. > > The keyword "vector" may conflict easily. > > As a rule, it is better to use the alternative keyword "__vector". > > > > The DPDK header file rte_altivec.h takes care of undefining "vector", > > so the applications and dependencies are free to define the name "vector". > > > > This is a compatibility breakage for applications which were using > > the keyword "vector" for its AltiVec meaning. > > > > Signed-off-by: Thomas Monjalon > > --- > > doc/guides/rel_notes/release_22_07.rst | 5 +++++ > > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ > > 2 files changed, 12 insertions(+) > > > > Acked-by: Ray Kinsella Just to make sure, we are all OK to break compatibility of rte_altivec.h? It means the keyword vector is not available anymore with this #include. Please confirm it is OK to merge in DPDK 22.07.