From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] hash: fix build error due to missing include
Date: Wed, 24 Sep 2025 18:22:50 +0200 [thread overview]
Message-ID: <40844514.J2Yia2DhmK@thomas> (raw)
In-Reply-To: <6284832.6fTUFtlzNn@thomas>
24/09/2025 18:05, Thomas Monjalon:
> 24/09/2025 17:48, Bruce Richardson:
> > The file "rte_thash.c" uses the rte_cpu_get_flag_enabled() API but does
> > not include "rte_cpuflags.h". Add the include to fix build issues this
> > causes:
> >
> > ../lib/hash/rte_thash.c: In function ‘rte_thash_gfni_supported’:
> > ../lib/hash/rte_thash.c:79:13: error: implicit declaration of function
> > ‘rte_cpu_get_flag_enabled’ [-Wimplicit-function-declaration]
> > 79 | if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_GFNI) &&
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: d8f0f514428e ("eal/x86: remove useless include from spinlock header")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> How is that possible that I don't see this error in my compilations?
That's because we see it only on CPU having GFNI.
Applied, thanks.
prev parent reply other threads:[~2025-09-24 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 15:48 Bruce Richardson
2025-09-24 16:05 ` Thomas Monjalon
2025-09-24 16:16 ` Bruce Richardson
2025-09-24 16:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40844514.J2Yia2DhmK@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).