From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 33DE8377C for ; Wed, 25 May 2016 20:56:27 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id a136so140812984wme.0 for ; Wed, 25 May 2016 11:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=jD364WQx1ucCyj+kbbBYf7chpFmbXXKakLvMOoEoxVE=; b=bfQbTYTT9LhkcuQjP14ubsqhmuerSSEu3Tmf10vm4bMQaCRP61jr3dHZxXLFHQysCT 36myxmx6kjEHadrr9fXzU/tSn+0a8oNp/RU8dtvpAFm15NOUry9S5WJwDwz9qxuK5RRq 1E8kT+2rDObkayHPdVcsb/7u9nW6Z4MYK5ay5tnK1jWL2R8Ahs/AkAkS4vL9AvpzlFhn h1+M6z2eAobDKG251OxrgoyD7BtmdPZojEytUFKn8A3Dmxue3rOca4g6QdMg0ypjwL/x 7sB4qVIdU3Mc9ok+B3wTVqFj5zwXyBOQ+JYWQ6ajTFEAY/TAS1FgvE7Pb2vHYW7AQ55O MMRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=jD364WQx1ucCyj+kbbBYf7chpFmbXXKakLvMOoEoxVE=; b=I1Z+i9xv9jL7gwTP36fEIOHK5ukDs6oSofI4FTqjuSFXzYxQo8hQ2DFeTnfoj5ajWe 0PJLv0iCjjrTgQ2UjMzFXK9RG2sWjqShFRZhTXX3sUMFFuD6/DCS4KgJ4DAxrt+jKeAq H5SIGls15G9/YZNkoI4qMLwb2SzqsZobv+OsZLonla6oZ1/7yd/CVu52Ge2fYdLmBEyv BJUY+tt3BTHvZ+PEF33QSZ+lmEqUW4PYsrdbeQfzGsAzP68Pt9XPLXVzG509DggK/MCm QKHWCPSCQAoyV0w5vW1H1I4URFnUmlO6tsF8GtrZsx9LTyAMDMUjl+4vzg/QgL3xdeZC np/A== X-Gm-Message-State: ALyK8tJBDKLfsDykXZbC6Z/jjbVVXDj9bfw6sOh2u3pwZoxFB4MzMRvIZvr2MNwj7Wp+Ypee X-Received: by 10.28.217.72 with SMTP id q69mr4980427wmg.81.1464202586939; Wed, 25 May 2016 11:56:26 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q194sm4528407wme.18.2016.05.25.11.56.25 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 11:56:26 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen Date: Wed, 25 May 2016 20:56:25 +0200 Message-ID: <4086744.quTHnGcz6Y@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160525174051.GD14322@hmsreliant.think-freely.org> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1591100.WzDkHNrJoU@xps13> <20160525174051.GD14322@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv4 4/5] Makefile: Do post processing on objects that register a driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 18:56:27 -0000 2016-05-25 13:40, Neil Horman: > On Wed, May 25, 2016 at 07:08:19PM +0200, Thomas Monjalon wrote: > > 2016-05-24 15:41, Neil Horman: > > > + echo MODGEN $@; \ > > > + OBJF=`readlink -f $@`; \ > > > + ${RTE_OUTPUT}/buildtools/pmdinfogen \$$OBJF \$$OBJF.mod.c; \ > > > > Maybe .pmd.c would be more appropriate than .mod.c? > fine > > What means mod/MODGEN/MODBUILD? > GENerate Module information & BUILD module information. I think "module" is not appropriate here. > > It deserves to be in a shell script, at least to ease testing. > What do you mean by "it" and why would it be easier to test in a shell script? "it" is mostly this whole patch. With a shell script, we can test the behaviour on one file easily. Maybe I'm wrong, but I don't like having too much lines in a Makefile rule. We probably need more opinions.