From: Thomas Monjalon <thomas@monjalon.net>
To: "Su, Simei" <simei.su@intel.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"orika@mellanox.com" <orika@mellanox.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion
Date: Sat, 10 Aug 2019 22:39:00 +0200 [thread overview]
Message-ID: <4087788.iZrK4fg8Mc@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A62A63@irsmsx105.ger.corp.intel.com>
06/08/2019 16:45, Ananyev, Konstantin:
> From: Thomas Monjalon
> > 04/07/2019 06:43, simei:
> > > From: Simei Su <simei.su@intel.com>
> > >
> > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This
> > > can support symmetric hash function by rte_flow RSS action.
> > >
> > > Signed-off-by: Simei Su <simei.su@intel.com>
> > > ---
> > > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion.
> >
> > That's unfortunate there is a typo in the name of the enum you want to change.
> >
> > Do you have any reference to the algo you want to support? A paper maybe?
>
> If I am not mistaken that's just an intent to enable symmetric RSS hash-function via standard RSS rte_flow API -
> feature already available with i40e and newest Intel HW.
> (AFAIK on i40e right now it could be configured via RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT).
> If so, then I think the author may need to mention what PMDs will support that feature in 19.11.
Without any more comment, this patch cannot be accepted in 19.08.
prev parent reply other threads:[~2019-08-10 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 4:43 simei
2019-08-06 11:34 ` Thomas Monjalon
2019-08-06 14:45 ` Ananyev, Konstantin
2019-08-10 20:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4087788.iZrK4fg8Mc@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).