From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CC75A00E6 for ; Sat, 10 Aug 2019 22:39:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18C522B8C; Sat, 10 Aug 2019 22:39:06 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id D3E02231E for ; Sat, 10 Aug 2019 22:39:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 2A8111950; Sat, 10 Aug 2019 16:39:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 10 Aug 2019 16:39:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5j0HYispmciOWgOVWpMwF9Nt/TIc/bBPMnMLUrejJuU=; b=dixj4Ba1XvxK 46owcMO736K2fc40fIIr9M5H0WVZVMGdIfR8USddVZAtVNY/LNI2QbT9TQEM9HWq ZbHM+RNk9Bw+0eh28e2MjIdzvai8tWY0NR2V3xZI78lMLV45rnB9PDoAo42S8wqI 02u83JLH0q7z4diJedczh5BqLOMUjfw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=5j0HYispmciOWgOVWpMwF9Nt/TIc/bBPMnMLUrejJ uU=; b=tAwDMUDrxf7Ni0h1be6e8eq06a2+/vx+BxtQ4cHQa7GIDEuEdgnRLhrlI /2RRavvV5Cg5Zo2ZV7QJhXfrf7krv6qFy9KffiWNWnfw9JUFP4B+HlxaLdERzgX4 9zQuWxNvIgpuw3/6RbgS/aOAyDDBUjurhT/NDvA15ms5NqeQujIU2IRvkCvA+vtp 23X4y+MI4U50ZBs92/duAVM7itSbpJJN4I/lDltv/9h5FudlNcHgPI4VAMDhlSR/ seL7heKxTzGZ09J1Z3oFdqndIKUE8LPnozZ9JtJIzMLXoBLPqig9iFFqbOpOQETA s5dLVZ41SoIfW7ZzKwzjUHbftytcw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduledgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D836B8005C; Sat, 10 Aug 2019 16:39:01 -0400 (EDT) From: Thomas Monjalon To: "Su, Simei" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, Qiming" , "orika@mellanox.com" , "adrien.mazarguil@6wind.com" , "arybchenko@solarflare.com" , "Yigit, Ferruh" Date: Sat, 10 Aug 2019 22:39:00 +0200 Message-ID: <4087788.iZrK4fg8Mc@xps> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A62A63@irsmsx105.ger.corp.intel.com> References: <1562215437-75338-1-git-send-email-simei.su@intel.com> <24089372.lu3vrpdBSV@xps> <2601191342CEEE43887BDE71AB9772580168A62A63@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/08/2019 16:45, Ananyev, Konstantin: > From: Thomas Monjalon > > 04/07/2019 06:43, simei: > > > From: Simei Su > > > > > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This > > > can support symmetric hash function by rte_flow RSS action. > > > > > > Signed-off-by: Simei Su > > > --- > > > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion. > > > > That's unfortunate there is a typo in the name of the enum you want to change. > > > > Do you have any reference to the algo you want to support? A paper maybe? > > If I am not mistaken that's just an intent to enable symmetric RSS hash-function via standard RSS rte_flow API - > feature already available with i40e and newest Intel HW. > (AFAIK on i40e right now it could be configured via RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT). > If so, then I think the author may need to mention what PMDs will support that feature in 19.11. Without any more comment, this patch cannot be accepted in 19.08.