From: Simei Su <simei.su@intel.com> Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This can support symmetric hash function by rte_flow RSS action. Signed-off-by: Simei Su <simei.su@intel.com> --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e2721fa..540285b 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -99,3 +99,5 @@ Deprecation Notices to set new power environment if power environment was already initialized. In this case the function will return -1 unless the environment is unset first (using ``rte_power_unset_env``). Other function usage scenarios will not change. + +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion. -- 1.8.3.1
04/07/2019 06:43, simei:
> From: Simei Su <simei.su@intel.com>
>
> Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This
> can support symmetric hash function by rte_flow RSS action.
>
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
> +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion.
That's unfortunate there is a typo in the name of the enum you want to change.
Do you have any reference to the algo you want to support? A paper maybe?
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, August 6, 2019 12:35 PM > To: Su, Simei <simei.su@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Yang, > Qiming <qiming.yang@intel.com>; orika@mellanox.com; adrien.mazarguil@6wind.com; arybchenko@solarflare.com; Yigit, Ferruh > <ferruh.yigit@intel.com> > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion > > 04/07/2019 06:43, simei: > > From: Simei Su <simei.su@intel.com> > > > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This > > can support symmetric hash function by rte_flow RSS action. > > > > Signed-off-by: Simei Su <simei.su@intel.com> > > --- > > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion. > > That's unfortunate there is a typo in the name of the enum you want to change. > > Do you have any reference to the algo you want to support? A paper maybe? If I am not mistaken that's just an intent to enable symmetric RSS hash-function via standard RSS rte_flow API - feature already available with i40e and newest Intel HW. (AFAIK on i40e right now it could be configured via RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT). If so, then I think the author may need to mention what PMDs will support that feature in 19.11. Konstantin > >
06/08/2019 16:45, Ananyev, Konstantin:
> From: Thomas Monjalon
> > 04/07/2019 06:43, simei:
> > > From: Simei Su <simei.su@intel.com>
> > >
> > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This
> > > can support symmetric hash function by rte_flow RSS action.
> > >
> > > Signed-off-by: Simei Su <simei.su@intel.com>
> > > ---
> > > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric hash funtion.
> >
> > That's unfortunate there is a typo in the name of the enum you want to change.
> >
> > Do you have any reference to the algo you want to support? A paper maybe?
>
> If I am not mistaken that's just an intent to enable symmetric RSS hash-function via standard RSS rte_flow API -
> feature already available with i40e and newest Intel HW.
> (AFAIK on i40e right now it could be configured via RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT).
> If so, then I think the author may need to mention what PMDs will support that feature in 19.11.
Without any more comment, this patch cannot be accepted in 19.08.