* [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
@ 2017-01-23 5:02 Rasesh Mody
2017-01-23 6:43 ` Andrew Rybchenko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rasesh Mody @ 2017-01-23 5:02 UTC (permalink / raw)
To: ferruh.yigit; +Cc: Rasesh Mody, arybchenko, dev, Dept-EngDPDKDev
This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
Fixes: ec94dbc57362 ("qede: add base driver")
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +-
drivers/net/qede/base/reg_addr.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c
index a5437b5..77f9152 100644
--- a/drivers/net/qede/base/ecore_init_fw_funcs.c
+++ b/drivers/net/qede/base/ecore_init_fw_funcs.c
@@ -89,7 +89,7 @@ enum CmInterfaceEnum {
#define QM_STOP_CMD_STRUCT_SIZE 2
#define QM_STOP_CMD_PAUSE_MASK_OFFSET 0
#define QM_STOP_CMD_PAUSE_MASK_SHIFT 0
-#define QM_STOP_CMD_PAUSE_MASK_MASK -1
+#define QM_STOP_CMD_PAUSE_MASK_MASK 0xffffffff /* @DPDK */
#define QM_STOP_CMD_GROUP_ID_OFFSET 1
#define QM_STOP_CMD_GROUP_ID_SHIFT 16
#define QM_STOP_CMD_GROUP_ID_MASK 15
diff --git a/drivers/net/qede/base/reg_addr.h b/drivers/net/qede/base/reg_addr.h
index ab88671..3c369aa 100644
--- a/drivers/net/qede/base/reg_addr.h
+++ b/drivers/net/qede/base/reg_addr.h
@@ -30,7 +30,7 @@
24
#define CDU_REG_CID_ADDR_PARAMS_NCIB ( \
- 0xff << 24)
+ 0xffUL << 24) /* @DPDK */
#define XSDM_REG_OPERATION_GEN \
0xf80408UL
@@ -436,11 +436,11 @@
#define NIG_REG_LLH_FUNC_FILTER_VALUE 0x501a00UL
#define XMAC_REG_CTRL_TX_EN (0x1 << 0)
#define XMAC_REG_CTRL_RX_EN (0x1 << 1)
-#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xff << 24)
+#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xffUL << 24) /* @DPDK */
#define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE (0xff << 16)
#define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE_SHIFT 16
#define CDU_REG_SEGMENT1_PARAMS_T1_TID_BLOCK_WASTE (0xff << 16)
-#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xff << 24)
+#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xffUL << 24) /* @DPDK */
#define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK (0xfff << 0)
#define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK_SHIFT 0
#define CDU_REG_SEGMENT0_PARAMS_T0_NUM_TIDS_IN_BLOCK (0xfff << 0)
--
1.7.10.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
2017-01-23 5:02 [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation Rasesh Mody
@ 2017-01-23 6:43 ` Andrew Rybchenko
2017-01-23 10:21 ` Thomas Monjalon
2017-01-23 13:30 ` Ferruh Yigit
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2017-01-23 6:43 UTC (permalink / raw)
To: Rasesh Mody, ferruh.yigit; +Cc: dev, Dept-EngDPDKDev
On 01/23/2017 08:02 AM, Rasesh Mody wrote:
> This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
>
> Fixes: ec94dbc57362 ("qede: add base driver")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
> drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +-
> drivers/net/qede/base/reg_addr.h | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c
> index a5437b5..77f9152 100644
> --- a/drivers/net/qede/base/ecore_init_fw_funcs.c
> +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c
> @@ -89,7 +89,7 @@ enum CmInterfaceEnum {
> #define QM_STOP_CMD_STRUCT_SIZE 2
> #define QM_STOP_CMD_PAUSE_MASK_OFFSET 0
> #define QM_STOP_CMD_PAUSE_MASK_SHIFT 0
> -#define QM_STOP_CMD_PAUSE_MASK_MASK -1
> +#define QM_STOP_CMD_PAUSE_MASK_MASK 0xffffffff /* @DPDK */
> #define QM_STOP_CMD_GROUP_ID_OFFSET 1
> #define QM_STOP_CMD_GROUP_ID_SHIFT 16
> #define QM_STOP_CMD_GROUP_ID_MASK 15
> diff --git a/drivers/net/qede/base/reg_addr.h b/drivers/net/qede/base/reg_addr.h
> index ab88671..3c369aa 100644
> --- a/drivers/net/qede/base/reg_addr.h
> +++ b/drivers/net/qede/base/reg_addr.h
> @@ -30,7 +30,7 @@
> 24
>
> #define CDU_REG_CID_ADDR_PARAMS_NCIB ( \
> - 0xff << 24)
> + 0xffUL << 24) /* @DPDK */
>
> #define XSDM_REG_OPERATION_GEN \
> 0xf80408UL
> @@ -436,11 +436,11 @@
> #define NIG_REG_LLH_FUNC_FILTER_VALUE 0x501a00UL
> #define XMAC_REG_CTRL_TX_EN (0x1 << 0)
> #define XMAC_REG_CTRL_RX_EN (0x1 << 1)
> -#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xff << 24)
> +#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xffUL << 24) /* @DPDK */
> #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE (0xff << 16)
> #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE_SHIFT 16
> #define CDU_REG_SEGMENT1_PARAMS_T1_TID_BLOCK_WASTE (0xff << 16)
> -#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xff << 24)
> +#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xffUL << 24) /* @DPDK */
> #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK (0xfff << 0)
> #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK_SHIFT 0
> #define CDU_REG_SEGMENT0_PARAMS_T0_NUM_TIDS_IN_BLOCK (0xfff << 0)
FreeBSD build is OK for me with the patch applied.
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
2017-01-23 5:02 [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation Rasesh Mody
2017-01-23 6:43 ` Andrew Rybchenko
@ 2017-01-23 10:21 ` Thomas Monjalon
2017-01-23 13:25 ` Ferruh Yigit
2017-01-23 13:30 ` Ferruh Yigit
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2017-01-23 10:21 UTC (permalink / raw)
To: Rasesh Mody; +Cc: dev, ferruh.yigit, arybchenko, Dept-EngDPDKDev
2017-01-22 21:02, Rasesh Mody:
> This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
Is it really specific to FreeBSD 11? I guess it is more about clang.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
2017-01-23 10:21 ` Thomas Monjalon
@ 2017-01-23 13:25 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2017-01-23 13:25 UTC (permalink / raw)
To: Thomas Monjalon, Rasesh Mody; +Cc: dev, arybchenko, Dept-EngDPDKDev
On 1/23/2017 10:21 AM, Thomas Monjalon wrote:
> 2017-01-22 21:02, Rasesh Mody:
>> This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
>
> Is it really specific to FreeBSD 11? I guess it is more about clang.
>
Right, this seem clang 3.8.0 issue, independent from FreeBSD version.
I will remove FreeBSD version information while applying.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
2017-01-23 5:02 [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation Rasesh Mody
2017-01-23 6:43 ` Andrew Rybchenko
2017-01-23 10:21 ` Thomas Monjalon
@ 2017-01-23 13:30 ` Ferruh Yigit
2 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2017-01-23 13:30 UTC (permalink / raw)
To: Rasesh Mody; +Cc: arybchenko, dev, Dept-EngDPDKDev
On 1/23/2017 5:02 AM, Rasesh Mody wrote:
> This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
>
> Fixes: ec94dbc57362 ("qede: add base driver")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
Applied to dpdk-next-net/master, thanks.
(FreeBSD version information removed from commit)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-23 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 5:02 [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation Rasesh Mody
2017-01-23 6:43 ` Andrew Rybchenko
2017-01-23 10:21 ` Thomas Monjalon
2017-01-23 13:25 ` Ferruh Yigit
2017-01-23 13:30 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).