From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D34FA0C4B; Mon, 8 Nov 2021 22:36:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0864340DF7; Mon, 8 Nov 2021 22:36:10 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 2C84940040 for ; Mon, 8 Nov 2021 22:36:09 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DADBF3201DE8; Mon, 8 Nov 2021 16:36:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 08 Nov 2021 16:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ZYkjX1H28UC8XcSta4IL4sMf/aSBjciptqFXNfPEFBI=; b=Toq+mhTrrvril+dt Yl/xEETXpd+E+MQDZj6fQtQPW/YoYJhX8GAyT3ksjK210GyhfSkEMufBfCh/BRAR n/4BuH4oHRVy7w3mrAAdBlAz2D+FuvR+0PU4nde6l7gNmLW5jV3BpMdpP/jiJ5XC jyCtkgvd1FXiXaxYVY/kDfz3Cq0heVDE+eU6f9H8+c0wBuMz4FiINWclfhO5G0rb cJWw5nkRGTGTTwZnW2bOm7v10PpCUZT3GMPj/QDSMUg1WCfOTyRmu4h3CLv49jMV j9/argSPI+BO9ng9OXrRfZam8nnEZyyeOiykfFmVVMHRJIzcnf+Ztd/1UjwNfgI3 Iqk4ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ZYkjX1H28UC8XcSta4IL4sMf/aSBjciptqFXNfPEF BI=; b=UMfmfIr+8sJ96iA3lGrFHULC1fo9umArAR3TlBfc6wbfcPBZnkDgFOKHt 93KeC8SyYap5ch/m2nmErI7tFOjzq/kjgER5wDoBw/ekCBmzbwS/dB7tZWQ3j1+3 XlWyU15kIKZStGHEv/G1Bfs02UzrWMCh9/vLira8P83XKBe0vgzpFAMmZv7RXmRJ Ih+TMUQSVuoatPHTpWiuEsnEOodiCso8cpSl4dqfTGKeBAEbIq4PcCdmzW+qtOrj 7cToBpsxTZ7h385wo05HHEerJtKImPiZdX5z/S2EcU5B4CcRKPgUpXxQlCTkVKX+ fkDzVN6ETfKo0pCzlM/3RjT6fF22Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddvgddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Nov 2021 16:36:06 -0500 (EST) From: Thomas Monjalon To: Konstantin Ananyev Cc: dev@dpdk.org, ferruh.yigit@intel.com, mdr@ashroe.eu Date: Mon, 08 Nov 2021 22:36:05 +0100 Message-ID: <40912187.gXRZthq1ag@thomas> In-Reply-To: <20211108135555.24164-3-konstantin.ananyev@intel.com> References: <20211108115136.9998-1-konstantin.ananyev@intel.com> <20211108135555.24164-1-konstantin.ananyev@intel.com> <20211108135555.24164-3-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] ip_frag: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2021 14:55, Konstantin Ananyev: > Update public macros to have RTE_IP_FRAG_ prefix. > Remove obsolete macro. > Update DPDK components to use new names. I think you should keep old names for compatibility during some time. We should rename the function rte_frag_table_del_expired_entries to start with rte_ip_frag_ like others. > --- a/lib/ip_frag/rte_ip_frag.h > +++ b/lib/ip_frag/rte_ip_frag.h > @@ -27,22 +27,19 @@ extern "C" { > > struct rte_mbuf; > > -#define IP_FRAG_DEATH_ROW_LEN 32 /**< death row size (in packets) */ > +#define RTE_IP_FRAG_DEATH_ROW_LEN 32 /**< death row size (in packets) */ > > /* death row size in mbufs */ > -#define IP_FRAG_DEATH_ROW_MBUF_LEN \ > - (IP_FRAG_DEATH_ROW_LEN * (RTE_LIBRTE_IP_FRAG_MAX_FRAG + 1)) > +#define RTE_IP_FRAG_DEATH_ROW_MBUF_LEN \ > + (RTE_IP_FRAG_DEATH_ROW_LEN * (RTE_LIBRTE_IP_FRAG_MAX_FRAG + 1)) > > /** mbuf death row (packets to be freed) */ > struct rte_ip_frag_death_row { > uint32_t cnt; /**< number of mbufs currently on death row */ > - struct rte_mbuf *row[IP_FRAG_DEATH_ROW_MBUF_LEN]; > + struct rte_mbuf *row[RTE_IP_FRAG_DEATH_ROW_MBUF_LEN]; > /**< mbufs to be freed */ > }; > > -/* struct ipv6_extension_fragment moved to librte_net/rte_ip.h and renamed. */ > -#define ipv6_extension_fragment rte_ipv6_fragment_ext > - > /** > * Create a new IP fragmentation table. > * > @@ -128,7 +125,7 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in, > struct rte_mbuf *rte_ipv6_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl, > struct rte_ip_frag_death_row *dr, > struct rte_mbuf *mb, uint64_t tms, struct rte_ipv6_hdr *ip_hdr, > - struct ipv6_extension_fragment *frag_hdr); > + struct rte_ipv6_fragment_ext *frag_hdr); > > /** > * Return a pointer to the packet's fragment header, if found. > @@ -141,11 +138,11 @@ struct rte_mbuf *rte_ipv6_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl, > * Pointer to the IPv6 fragment extension header, or NULL if it's not > * present. > */ > -static inline struct ipv6_extension_fragment * > +static inline struct rte_ipv6_fragment_ext * > rte_ipv6_frag_get_ipv6_fragment_header(struct rte_ipv6_hdr *hdr) > { > if (hdr->proto == IPPROTO_FRAGMENT) { > - return (struct ipv6_extension_fragment *) ++hdr; > + return (struct rte_ipv6_fragment_ext *) ++hdr; > } > else > return NULL;