From: Thomas Monjalon <thomas@monjalon.net>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
junjie.j.chen@intel.com, jianfeng.tan@intel.com,
stephen@networkplumber.org, ferruh.yigit@intel.com,
konstantin.ananyev@intel.com, lei.a.yao@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup
Date: Wed, 10 Jan 2018 01:09:07 +0100 [thread overview]
Message-ID: <4091994.Mte9QLjkTW@xps> (raw)
In-Reply-To: <1515132769-52572-2-git-send-email-jiayu.hu@intel.com>
Hi,
05/01/2018 07:12, Jiayu Hu:
> - Remove needless check and variants
> - For better understanding, update the programmer guide and rename
> internal functions and variants
> - For supporting tunneled gro, move common internal functions from
> gro_tcp4.c to gro_tcp4.h
> - Comply RFC 6864 to process the IPv4 ID field
I think you could split this patch in several ones.
Please remind that the git history can be used later to understand
why the changes were done.
Thanks
next prev parent reply other threads:[~2018-01-10 0:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 3:17 [dpdk-dev] [PATCH 0/2] Support VxLAN GRO Jiayu Hu
2017-11-25 3:17 ` [dpdk-dev] [PATCH 1/2] gro: TCP/IPV4 GRO codes cleanup Jiayu Hu
2017-11-25 3:17 ` [dpdk-dev] [PATCH 2/2] gro: support VxLAN GRO Jiayu Hu
2017-12-14 2:49 ` [dpdk-dev] [PATCH v2 0/2] Support " Jiayu Hu
2017-12-14 2:49 ` [dpdk-dev] [PATCH v2 1/2] gro: code cleanup Jiayu Hu
2017-12-14 2:49 ` [dpdk-dev] [PATCH v2 2/2] gro: support VxLAN GRO Jiayu Hu
2017-12-14 2:58 ` Stephen Hemminger
2017-12-14 3:02 ` Stephen Hemminger
2017-12-14 4:37 ` Hu, Jiayu
2017-12-22 7:25 ` [dpdk-dev] [PATCH v3 0/2] Support " Jiayu Hu
2017-12-22 7:25 ` [dpdk-dev] [PATCH v3 1/2] gro: code cleanup Jiayu Hu
2017-12-29 3:53 ` Chen, Junjie J
2018-01-02 11:26 ` Bruce Richardson
2018-01-03 1:07 ` Tan, Jianfeng
2018-01-03 1:27 ` Stephen Hemminger
2017-12-22 7:25 ` [dpdk-dev] [PATCH v3 2/2] gro: support VxLAN GRO Jiayu Hu
2017-12-22 8:17 ` Chen, Junjie J
2017-12-25 6:36 ` Jiayu Hu
2017-12-29 3:53 ` Chen, Junjie J
2017-12-29 3:52 ` [dpdk-dev] [PATCH v3 0/2] Support " Chen, Junjie J
2018-01-05 6:12 ` [dpdk-dev] [PATCH v4 " Jiayu Hu
2018-01-05 6:12 ` [dpdk-dev] [PATCH v4 1/2] gro: code cleanup Jiayu Hu
2018-01-08 1:15 ` Yao, Lei A
2018-01-10 0:09 ` Thomas Monjalon [this message]
2018-01-10 1:55 ` Hu, Jiayu
2018-01-05 6:12 ` [dpdk-dev] [PATCH v4 2/2] gro: support VxLAN GRO Jiayu Hu
2018-01-10 14:03 ` [dpdk-dev] [PATCH v5 0/3] Support " Jiayu Hu
2018-01-10 14:03 ` [dpdk-dev] [PATCH v5 1/3] gro: codes cleanup Jiayu Hu
2018-01-10 14:03 ` [dpdk-dev] [PATCH v5 2/3] gro: comply RFC 6864 to process IPv4 ID Jiayu Hu
2018-01-10 14:03 ` [dpdk-dev] [PATCH v5 3/3] gro: support VxLAN GRO Jiayu Hu
2018-01-11 22:15 ` [dpdk-dev] [PATCH v5 0/3] Support " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4091994.Mte9QLjkTW@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=jiayu.hu@intel.com \
--cc=junjie.j.chen@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lei.a.yao@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).