From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3AE752BC8
 for <dev@dpdk.org>; Wed, 10 Jan 2018 01:09:33 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B28EE205DE;
 Tue,  9 Jan 2018 19:09:32 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 09 Jan 2018 19:09:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=2aDzqZOc2ZCAidycSlKLVJ7LMW
 TT+i+WJ8MFtdukGDY=; b=qkd4zsg47oeILjYYUeRj3yatOnIxMFWb5WfkCtg055
 bq4r5SKi9HsJI/tUYl3OlGCUn6c3VXk73lDjEHMC4nWM1/UU+IhluMA7FNZZUGEE
 6TpFsMa61ELgq+yGB7EbVyo7r7497JKKD1Ej/Fy7WfmOsR9ELDDq8/UKEGGA9WkZ
 U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2aDzqZ
 Oc2ZCAidycSlKLVJ7LMWTT+i+WJ8MFtdukGDY=; b=ols+GOD2/639yVifEIbsjc
 pekC7IGfZPM9dbSaH5g2DkIJDEQs5KOn2DeZPJc+pQxbXgHLsweyFnPtDO8rhb/u
 lGEHXbv0C4o+BQ1RWNbaiqPWPS16Z1j3Ah9yMWbjfL2ghIHONhMtUCi3Y/BOj0iW
 tHysMms/dZY/rhCktXInwKybWwp8Lzc49CAuEaF8iuRi07R+pqIHJl6HlilSaPE4
 w+QyMZQKfomgJBpJR0gZvsR09RX/IdyZcKR1efWJfNhclblND6+tVTaFAOAFzEc1
 zvU265/piWfJ+lTtSr2+qpCQnXijEPUChS6u4UgbuX0xY12ff3aeSmZfUvDBEwwg
 ==
X-ME-Sender: <xms:vFlVWkha5-9RadcZMD28j3LCkPewfT8jNKmFo4g1-n7wub0VGTmrww>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 527AD7E34D;
 Tue,  9 Jan 2018 19:09:32 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, junjie.j.chen@intel.com,
 jianfeng.tan@intel.com, stephen@networkplumber.org, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, lei.a.yao@intel.com
Date: Wed, 10 Jan 2018 01:09:07 +0100
Message-ID: <4091994.Mte9QLjkTW@xps>
In-Reply-To: <1515132769-52572-2-git-send-email-jiayu.hu@intel.com>
References: <1513927544-97241-1-git-send-email-jiayu.hu@intel.com>
 <1515132769-52572-1-git-send-email-jiayu.hu@intel.com>
 <1515132769-52572-2-git-send-email-jiayu.hu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 1/2] gro: code cleanup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 00:09:33 -0000

Hi,

05/01/2018 07:12, Jiayu Hu:
> - Remove needless check and variants
> - For better understanding, update the programmer guide and rename
>   internal functions and variants
> - For supporting tunneled gro, move common internal functions from
>   gro_tcp4.c to gro_tcp4.h
> - Comply RFC 6864 to process the IPv4 ID field

I think you could split this patch in several ones.
Please remind that the git history can be used later to understand
why the changes were done.

Thanks