From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 21C822C52; Fri, 26 Oct 2018 22:41:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B2A0D21F01; Fri, 26 Oct 2018 16:41:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 16:41:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2fy1gXuv9twywZyCtRvkwVQHWv1K2OtR5n896ErSnns=; b=Mu63FhuXW0m8 HoN2DeIBhS6gVOVkAxATxWT/MsW3V1hdxO6lSvZasjfDnu6Y7yGSF8usjYeEaGwq 61St+HxnbSLEqcv97CuF9jlvLBrAkiB1whuh6dbLMaqg+hnjv98D16dnsYFrUKPk +oulZ/CluwmaluCjKjFNjTb0dNvGkkg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2fy1gXuv9twywZyCtRvkwVQHWv1K2OtR5n896ErSn ns=; b=qQV0cSUgIZc/8sQ5o6rfGpSVwzm/UGFkREHCXhIEhDHqJu1GUWvSQeup+ MkTWtSYhX68mhiMXJXzUuODkAwgek832igVaR1zTfw63Dikqla9jsc91xuoMCQwx u1gmQr3kWU1MXs7sZ6cXUq7zBHmsodc2PmkNtvhh9NoGGsrc1Wf1QjeFBcBfxWBh bsHgHM/koBppj1aa2p8cUazkypUGQ1fgchFtxgsDbVpVXfUiHJ40pgRJjzLEvscX kAs71FqpaQYNfR+NliwAuOKMPnmNZJJnFBQilB+GAf68gBlx1vdXCTJsrBl45tl7 9m+9dhzLeYSnCKmSGYwK69tp0LbdQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 555B4102DE; Fri, 26 Oct 2018 16:41:54 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: stable@dpdk.org, dev@dpdk.org, stephen@networkplumber.org, Stephen Hemminger Date: Fri, 26 Oct 2018 22:41:59 +0200 Message-ID: <4092104.WkhJc3HfzQ@xps> In-Reply-To: <7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com> References: <20180725182019.31518-4-stephen@networkplumber.org> <7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/mp: remove rte_panic and profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 20:41:56 -0000 26/10/2018 16:55, Anatoly Burakov: > --- a/lib/librte_eal/common/eal_common_proc.c > +++ b/lib/librte_eal/common/eal_common_proc.c > + /* > + * set the alarm before sending message. there are two possible error > + * scenarios to consider here: > + * > + * - if the alarm set fails, we free the memory right there > + * - if the alarm set succeeds but sending message fails, then the alarm > + * will trigger and clean up the memory > + * > + * Even if the alarm triggers too early (i.e. immediately), we're still > + * holding the lock to pending requests queue, so the interrupt thread > + * will just spin until we release the lock, and either release the > + * memory, or doesn't find any pending requests in the queue because we > + * never added any due to send message failure. > + */ > + if (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000, > + async_reply_handle, pending_req) < 0) { > + RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n", > + dst, req->name); > + goto fail; > + } ret variable is not set and not initialized.