From: Thomas Monjalon <thomas@monjalon.net>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org, drc@linux.vnet.ibm.com, maxime.coquelin@redhat.com,
zhihong.wang@intel.com, xiaolong.ye@intel.com,
konstantin.ananyev@intel.com, david.hunt@intel.com,
jerinj@marvell.com, skori@marvell.com, john.mcnamara@intel.com,
kirill.rybalchenko@intel.com, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: fix return value of function that parses portmask
Date: Thu, 30 Jul 2020 23:08:58 +0200 [thread overview]
Message-ID: <4092408.OuC6MW89ze@thomas> (raw)
In-Reply-To: <20200721160727.GI735@bricha3-MOBL.ger.corp.intel.com>
21/07/2020 18:07, Bruce Richardson:
> On Thu, Jun 11, 2020 at 05:36:24PM +0500, Sarosh Arif wrote:
> > Giving invalid or zero portmask as command line option to
> > these applications will have an unexpected response.
> > The reason behind this is that the return value of function
> > that parses portmask is stored in a variable whose datatype is
> > unsigned int, hence returning -1 in case of zero or
> > invalid portmask causes an unexpected behaviour.
> > If we return 0 instead of -1 this issue can be resolved.
> > The program already contains the functionality to print
> > "invalid portmask" and program usage if zero is returned.
> >
> > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> > ---
>
> Checked a number of the examples and all seem to behave similarly to
> described. This looks a good fix.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-07-30 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 12:36 Sarosh Arif
2020-07-11 10:00 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-07-21 16:07 ` [dpdk-dev] " Bruce Richardson
2020-07-30 21:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4092408.OuC6MW89ze@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=kirill.rybalchenko@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=sarosh.arif@emumba.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).