From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CE70B44BE; Mon, 22 Oct 2018 12:32:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5FAF321F26; Mon, 22 Oct 2018 06:32:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 06:32:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6WTPZIqB5hUyMLSDTUPGD4xwCOK75Jijxw4H+zz0QnQ=; b=Tc6wGUVkJ75H nCEagUpH+0xkoPgXfKZvG0AoLGWRrG4YmAMEx8jWgCoOzdoe0CvTufcfUcWQGIKC laxamuY/81hIeBZ+Kdoqwe24F+fUmtS6i65o475U5nN9ikPq4CiMUQi2M77zaox8 UPhfXeJ1XOhQQAlBi3bTIHHfqLT491U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=6WTPZIqB5hUyMLSDTUPGD4xwCOK75Jijxw4H+zz0Q nQ=; b=b0Xd/Nv6PB64Ei26QbZi9Fhb/HZhFijoX/WSfeIuK2S9mVkuLls4YAqmB OIhlV0fUlDNpK08PMFODQRMGWsfJv45hGnMssu+32xu6M/FoPJb/jJ8dIMMZblR5 a8yrpSjVZiVW/4LIW/CnyD4bdBzDfcUf/JsyfL7Uq0QRjjhGY0FLiKYKoibKZWJW dHJrlCjBbmfzL2Bch1Nyce58wU1/ptI57ZL09gP6+M6dQuSLyGgbbLuUoNpgUZ/l p3rG4jt/zh95yqtOTl8ay51S9C5AkIWrM2w6qlTWv5lCTxQPPdjrAWiqh5XeZz2X 5X4eMd1qhvbfv7GleC4ZUPxygA/1w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EBC3102A0; Mon, 22 Oct 2018 06:32:19 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: stable@dpdk.org, dev@dpdk.org, Ravi1.Kumar@amd.com Date: Mon, 22 Oct 2018 12:32:20 +0200 Message-ID: <4093296.dHmcqor6Pu@xps> In-Reply-To: <5e545d6548f62a8fddfca18f8cc0901654e1e403.1538728009.git.anatoly.burakov@intel.com> References: <5e545d6548f62a8fddfca18f8cc0901654e1e403.1538728009.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/linuxapp: improve segment list preallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 10:32:21 -0000 05/10/2018 10:29, Anatoly Burakov: > Current code to preallocate segment lists is trying to do > everything in one go, and thus ends up being convoluted, > hard to understand, and, most importantly, does not scale beyond > initial assumptions about number of NUMA nodes and number of > page sizes, and therefore has issues on some configurations. > > Instead of fixing these issues in the existing code, simply > rewrite it to be slightly less clever but much more logical, and > provide ample comments to explain exactly what is going on. > > We cannot use the same approach for 32-bit code because the > limitations of the target dictate current socket-centric > approach rather than type-centric approach we use on 64-bit > target, so 32-bit code is left unmodified. FreeBSD doesn't > support NUMA so there's no complexity involved there, and thus > its code is much more readable and not worth changing. > > Fixes: 1d406458db47 ("mem: make segment preallocation OS-specific") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks