From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BEADF2BAE for ; Mon, 11 Dec 2017 20:01:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 11:01:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="10998764" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.161]) ([10.241.225.161]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2017 11:01:27 -0800 To: Amr Mokhtar , dev@dpdk.org Cc: thomas@monjalon.net, anatoly.burakov@intel.com, pablo.de.lara.guarch@intel.com, niall.power@intel.com, chris.macnamara@intel.com References: <1512682857-79467-1-git-send-email-amr.mokhtar@intel.com> <1512682857-79467-3-git-send-email-amr.mokhtar@intel.com> From: Ferruh Yigit Message-ID: <409ed602-6bc4-d2e2-488d-5c512586173f@intel.com> Date: Mon, 11 Dec 2017 11:01:27 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512682857-79467-3-git-send-email-amr.mokhtar@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/5] bbdev: test applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 19:01:30 -0000 On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - Full test suite for bbdev > - Test App works seamlessly on all PMDs registered with bbdev > framework > - A python script is provided to make our life easier Can you please describe what the script is for? > - Supports execution of tests by parsing Test Vector files Can you please describe what are test vector files? > - Test Vectors can be added/deleted/modified with no need for > re-compilation > - Various Tests can be executed: > (a) Throughput test > (b) Offload latency test > (c) Operation latency test > (d) Validation test > (c) Sanity checks > > Signed-off-by: Amr Mokhtar <...> > +include $(RTE_SDK)/mk/rte.vars.mk > + > +ifeq ($(CONFIG_RTE_TEST_BBDEV),y) You don't need this ifdef I think, although I can see testpmd has it ... > + > +# > +# library name > +# > +APP = testbbdev > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + > +# > +# all sources are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += main.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_perf.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_vector.c If you remove above wrapping ifdef, you may use CONFIG_RTE_TEST_BBDEV instead. <...> > +int > +unit_test_suite_runner(struct unit_test_suite *suite) Is test-bbdev application a suit of test cases? What is the benefit of having separate application comparing adding unit tests to test/ folder? <...>