From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58CA245B4C; Wed, 16 Oct 2024 08:20:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FF184021F; Wed, 16 Oct 2024 08:20:35 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 049F7400D6 for ; Wed, 16 Oct 2024 08:20:33 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 9F5B9176C2 for ; Wed, 16 Oct 2024 08:20:33 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 92E9B176C0; Wed, 16 Oct 2024 08:20:33 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 89B6817666; Wed, 16 Oct 2024 08:20:25 +0200 (CEST) Message-ID: <40a329e4-d6a9-4e15-980e-33f199ced14b@lysator.liu.se> Date: Wed, 16 Oct 2024 08:20:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 10/10] eventdev: remove single event enqueue and dequeue From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= To: Stephen Hemminger , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob , dev@dpdk.org, David Marchand , Anoob Joseph , Hemant Agrawal , Sachin Saxena , Abdullah Sevincer , Pavan Nikhilesh , Shijith Thotton , Harry van Haaren , Ashwin Sekhar T K References: <20241015084943.823983-2-mattias.ronnblom@ericsson.com> <20241015182535.825098-1-mattias.ronnblom@ericsson.com> <20241015182535.825098-11-mattias.ronnblom@ericsson.com> <20241015150020.7d1a57f4@hermes.local> <512b6388-bbf0-4afe-aa9f-7507f50c55a3@lysator.liu.se> Content-Language: en-US In-Reply-To: <512b6388-bbf0-4afe-aa9f-7507f50c55a3@lysator.liu.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-10-16 06:36, Mattias Rönnblom wrote: > On 2024-10-16 00:00, Stephen Hemminger wrote: >> On Tue, 15 Oct 2024 20:25:35 +0200 >> Mattias Rönnblom wrote: >> >>> Remove the single event enqueue and dequeue, since they did not >>> provide any noticable performance benefits. >>> >>> This is a change of the ABI, previously announced as a deprecation >>> notice. These functions were not directly called by the application, >>> so the API remains unaffected. >>> >>> Signed-off-by: Mattias Rönnblom >> >> Still have a build failure with one driver. >> > > The wonders of #ifdef . > I had a closer look at this, and given the elaborate macro-based machinery and the ARM-only conditional compilation it's better if a driver maintainer does the required changes. (It's probably better to start from scratch on the cnxk patch, rather than looking at anything I did.) Ashwin Sekhar or Pavan Nikhilesh, is this something you can do? >> >> -------------------------------BEGIN LOGS---------------------------- >> #################################################################################### >> #### [Begin job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build >> and test >> #################################################################################### >>        |         ^~~~~~ >> ../drivers/event/cnxk/cn9k_eventdev.c: In function ‘cn9k_sso_fp_fns_set’: >> ../drivers/event/cnxk/cn9k_eventdev.c:576:20: error: ‘struct >> rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’? >>    576 |         event_dev->enqueue = cn9k_sso_hws_enq; >>        |                    ^~~~~~~ >>        |                    ca_enqueue >> ../drivers/event/cnxk/cn9k_eventdev.c:576:30: error: >> ‘cn9k_sso_hws_enq’ undeclared (first use in this function); did you >> mean ‘cn9k_sso_hws_link’? >>    576 |         event_dev->enqueue = cn9k_sso_hws_enq; >>        |                              ^~~~~~~~~~~~~~~~ >>        |                              cn9k_sso_hws_link >> ../drivers/event/cnxk/cn9k_eventdev.c:584:28: error: ‘struct >> rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’? >>    584 |                 event_dev->enqueue = cn9k_sso_hws_dual_enq; >>        |                            ^~~~~~~ >>        |                            ca_enqueue >> ../drivers/event/cnxk/cn9k_eventdev.c:584:38: error: >> ‘cn9k_sso_hws_dual_enq’ undeclared (first use in this function); did >> you mean ‘cn9k_sso_hws_dual_ca_enq’? >>    584 |                 event_dev->enqueue = cn9k_sso_hws_dual_enq; >>        |                                      ^~~~~~~~~~~~~~~~~~~~~ >>        |                                      cn9k_sso_hws_dual_ca_enq >> [2451/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at >> sta/event_cnxk_deq_cn9k_deq_64_79_seg_burst.c.o'. >> [2452/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at >> sta/event_cnxk_deq_cn9k_deq_80_95_seg_burst.c.o'. >> [2453/4290] Generating rte_crypto_octeontx.sym_chk with a meson_exe.py >> custom command. >> [2454/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at >> sta/event_cnxk_deq_cn9k_deq_96_111_seg_burst.c.o'. >> [2455/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at >> sta/event_cnxk_deq_cn9k_deq_112_127_seg_burst.c.o'. >> ninja: build stopped: subcommand failed. >> ##[error]Process completed with exit code 1. >> #################################################################################### >> #### [End job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build and >> test >> #################################################################################### >> --------------------------------END LOGS----------------------------- >