From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0042.outbound.protection.outlook.com [104.47.37.42]) by dpdk.org (Postfix) with ESMTP id 694DB2B87 for ; Fri, 7 Apr 2017 17:27:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jXPb4DKMLNGDEFx5VGBRytV/12qHxwKSb99hvLdeifE=; b=n43QUtFlNoIrhuH+AKKUxz4HLyYqeXsOjtlAaOdC2CRTJ31l+wdWeReo9AFreP/JSSZ2VM3QjI2La4iloprHYaeVEyDpe4tNXsdWmY56DPxdUAz2Wn8E5p4WFeznRX0Dl7nJgUUOKrigo8+P1cQbWU4LAZR4XzomM6Q1B3owAbc= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.0.75] (31.172.191.173) by BLUPR0701MB1027.namprd07.prod.outlook.com (10.160.35.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Fri, 7 Apr 2017 15:27:21 +0000 To: Thomas Monjalon , Bruce Richardson References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <20170407122956.GA26192@bricha3-MOBL3.ger.corp.intel.com> <2875009.PBUn9ZmEvk@xps13> Cc: dev@dpdk.org From: Andriy Berestovskyy Message-ID: <40c13c68-aadf-1665-a301-7d74be3017cd@caviumnetworks.com> Date: Fri, 7 Apr 2017 17:27:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2875009.PBUn9ZmEvk@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: AM5P194CA0022.EURP194.PROD.OUTLOOK.COM (10.175.19.160) To BLUPR0701MB1027.namprd07.prod.outlook.com (10.160.35.19) X-MS-Office365-Filtering-Correlation-Id: e64acef6-d62e-417e-fdda-08d47dca963b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1027; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 3:QIcCOhh5G1bHEVEZyHQLLg4c9ua63ch9jlhZo6tbdwOJo2YaDp9BbUYDO5m6GoRkiF+aboV5C5L2zuTBGHfOCA9MT3YMAnSvFCxpEbyqrn7HW76xDJU2xHttsKS6K8sSqS7GcpT+4uFbgAeSQcP+n3fuCr1p0UBajMUaTlZRMSYmmdJJlEw2CzifrzB2sMrR8KjMviI40eyLZt+qLC6BS53l2Sn/bhXYyTbJXDUptrSzoZb5UqhOIphGRxgG71Wey6/jYecDTUJrFmAnu1KZpzvj8ZQz1vwSWuUWfbiPO8SEIkJfHCMC9t6TXC560oHXfdUplHfmF/I6Von9ynSBEA==; 25:VwrZZNl98Hy1b2xggjSERofA3wzb1L0mU2ylv2rkFfT6KqTF2nyjAmGS8BU4elnBEyBcOC07uYU2XmCIZkSd3xyeL5TU/SoZqSwm7TRmz/Syr4SEvTvQiWVqwermQsJoU3ko77CSnAudKnh1dbUCHdLWMM+X7L/bqzRfnN2NbgGoJwh7Cr7Uu5UrvXwHGU1Bb/pM9MVZiWCdv8jyGn+zFLBP1OQ2uavOoLvo4l2LHCViBcdBkbCtV5iH/5cBCSE3081+whmN/nMhARZjL85O69I6Hm3lptcb0UbE+vcAIg7ekNcmP68MhO4I2mvgt/Cihb5pLCL7Vb5gh/3H1Gd7Pc0ec4R/hgUpChl8SOjV9lEjbLAsfWwbNSDqQ/odVkBpyrmesHj4ZRkYv2ivVZGP2HJscj7EnxhbtqubFiWPPuwvEiCoDfkBN7M1886wpL/P3XxQvnMM9hHfCd6WAf4Xzg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 31:Xd8y5Bt21gWLwQFmIHbBo+viETkwiNjVHtWtxaR+m/XDv3eA6n/nR9AvF+lb1lJFJY6OEsCi49LYiUFIECcSLkiz6Ralu07lfBXi7/S1oF9jpQnbUCMCfv0MOO1BHpI5mjFvb9Rm5Jimi57DIuI1FPXTOXS1AQ8JTapj9Q53HqvIqOAUJ/SD8fliQQRRc6SyiWiQwogHtRLWFI1YYKyKedsNMpqvkmRIenCauiazbfOpWd4iE1+H19qyLSswf6slnGv2OOqQBCGiS9VRAgnVDmgh884Hjb+a/h64tAUJDrU=; 20:4LYmqWeLoe1Y/7V3kdpKFea0InlEnhp6IHIEbzyQCgfTwqaMd9ZJSsD3omibYP8ll9PLxpFV63TjpNwQY4QaFQKbLcOqSx2Pjp0iKejcjykeJ+q1ciICHr8A1KQpdxqlhFna5ZLA1S5/HneJI4zSUsvsBLGudwdctQfGiWmUGSk76cZHAtVFBEDyjIAnSZqchL9Rm38l1WHaFJgUzzdgM7yqlCHOHue1XZF9rVDEaaWEVUnsY1j9cT86o1js4tfdnYgyGIsgk4ArlKNtjuIRt6+loKl30iUPymEKtsGf6TuTPh/sYBtv1DwAhd/0Bm4R8eYtV2uMHunXYOV8AHw+syVb0ec0fKK7HPkrdSouBqv7mIZsisliNQ0VBxDHsc5WPDQf9agrIYkBrEq9nCufk+EbUVIunTIXH9dMp3mukpELU3mWAcyCISyvTKxmxhF8kpywsLMsEFXeegnevuh0v0stAedJSRhhSA6+8OByq/JandsGCtgUpTbrqqgwOooXxGfmn7sVS9BqLuVCGEcfENhLsMWY3MKDQ2foDv+sbHG05X0h/BehMAQFXXiMsocFCjkJuaBqkf0lvmH+1YwUmWFLedJPcP3Z5UqQhIcQEKY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123555025)(6072148); SRVR:BLUPR0701MB1027; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1027; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 4:ozeTpKovOzaL0dmBtK+LzrmF6yvSv5xKTtlLPC0aczKld2up4OUurKN8Sprd+mXu2sCGZAcndSIbf3RJUKEPOcy3KOMJv8TejsOP+fenPKsCFsXw89JVFMc7m0WeWFrTxQG/v5IYB8NEav8/SncztAEmXAcW2HyAruiH4dQgW3fVyEbcUWihK0yh/L3Ezs8OWVtuKBdVQht7XSqDG9shjocuBR9raxNsfugVgGtx3esBcbB4Zo0Ejsl6UYwAQ9WxjzQCXos76iltfVR/bI9kw2eoJucObNqHM7AwLLd3aUXjMUJgHmASjWwA0FmsEtGKUY6E/KtZ7NgrbzBFFZmFB3Dr8pCq0C8SNppvpNgdT5g/romHp6VYy855/qh5KkIiAd6Tp51zMGnFBk8JWuZo+yPSn6fGClPSklrs0xJEAbaGpYvB8IxGyKrteCcR7JMNBASbp5geh6YBTYZm2nfa/hcYqVZLJfCsBNx01kpFuVigTOXqIbEhAcGnHEFBgDfjqTDHuzcl/3OlMLaJUk3V9OmlzVaxnBnk/B7mPOMPPa9Ps5lI1uUtdgbf9RQuAdHFTF0e2UAZvdii+DyaiNuxvwpB0UIwOGJtpncNhwQKtZbZEijGwiUesmHUbJguzItnrNqB11OAGFayXNm3LMWxwL2Qo+hMsyhw2bRWr2r8i4PrA6Kee2RilDuzzDQkLsWZ X-Forefront-PRVS: 0270ED2845 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39410400002)(39400400002)(39850400002)(39450400003)(24454002)(90366009)(83506001)(93886004)(36756003)(65956001)(5660300001)(53936002)(66066001)(6486002)(23746002)(31696002)(47776003)(305945005)(77096006)(7736002)(229853002)(4001350100001)(189998001)(6246003)(3846002)(6116002)(33646002)(50466002)(38730400002)(42186005)(2906002)(53546009)(230700001)(31686004)(76176999)(50986999)(6666003)(54356999)(42882006)(4326008)(8676002)(25786009)(81166006)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1027; H:[10.0.0.75]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0701MB1027; 23:f/aIOL+GkkQymNBAkDrut6v4tSwq03u1tQv?= =?Windows-1252?Q?fAx6MBn6dhiWfTS/LD8rXdpH5V3oVQAinPTP1SBxRwwwdBHojnmUuJ2g?= =?Windows-1252?Q?cxQGIBdONZ0ngC1sGn9H6ybjugxgx7nY60/XINmnsNhD+ZviCBTFq1uj?= =?Windows-1252?Q?wExzpILpNWXP30jcSn7Hl5NwJM7uTvlB1SIzsw8zcUEe4x2E9a0Z8OaU?= =?Windows-1252?Q?3xRvd26GI75fq1PFFiZtLFnp9u57lHsg0l4pgP+3ioSW1ZjsqRUBpH3K?= =?Windows-1252?Q?pdaaIMwu4jtbeQtcvzBn73qFhQqPFYeqe1lk5WYoc5yHplhtqaMYAsfR?= =?Windows-1252?Q?twQsv9VyYQlS/GXSpt9enixeU3SEIo3ZYX+CjSZe2/4wp8Hyc3qHkZPe?= =?Windows-1252?Q?mkBx4NfYG7I9jaBW3cGtSKObLacCvnVVg64y781jUP31mZwCA/Mj21PM?= =?Windows-1252?Q?v8f1QTNWpB1n0WBh4jHTrX6exjFHETnfdiPtJWNPKqQjmg2OxXsBPHO5?= =?Windows-1252?Q?KOvvMpHOxckpOBcOii8USmmyBtCkHY/oIbCvoytC/UiTnlrZX4cQKknA?= =?Windows-1252?Q?uosgpoaGlGRLm2rtEtg5WtGYUW5Ko4XYIIeQWRXP6HEKZpE/GRnjMRz0?= =?Windows-1252?Q?4orHoyonSGdpBpxCasX9qPWE4TvgfETQDm56odB9GUzDm1/OwOwJ8OKu?= =?Windows-1252?Q?pZYr4y43pZGWmBRNH/Aa6moimFUpbpVmGMWQ89qYrPdVDfHk5I9H43U0?= =?Windows-1252?Q?xi69fQB+szDKcq/hpQ84PHysDHo6dGJqdZIkWSWtLQhKtjpwb/JxCwMa?= =?Windows-1252?Q?+l/LmdvOHTqqIFALhjZzLq6kqm25SZpG0AT66sLeqPLZ6NnEQMcHycFx?= =?Windows-1252?Q?xt2Q5AOfOWGQEcSe5LpYNyGO8zfz4ZDGAdrFuB2dr0DYEwwwz3c1YGfR?= =?Windows-1252?Q?eigl9hF8G33JldT2lByDLQtW2nixUfpWvQs4mrjN278e9tEmdONkq9cP?= =?Windows-1252?Q?qq/o++8aJm4B3+0kLXMY1Opq5Q/e3CPxSWh80lCsSXVkxWWtWv8hihZH?= =?Windows-1252?Q?z6qSGUl1cscfwAKxnuV5mdiTs0tu9uOoCJuGM34pdKgLCLkYTapcxaVe?= =?Windows-1252?Q?u2m40C9iNWPzJByG4+nz8Cp5G9Dk6cmZYyAqp/xg/Xk44DbQH+GXnWpW?= =?Windows-1252?Q?XiNS+NDvW9QbbGSA5h2D3ExxHv7hLshJcAPUhmejpDsVAqS+HARMPdlU?= =?Windows-1252?Q?UNTj6qglOBvc3su9yF0nfiakXWbiQ0NR28H8TLurJxOTF9o1M5ZSm8/+?= =?Windows-1252?Q?yRLn0?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 6:o68cuRlCsjByuYLypos5HPxH0Ci0+nB9VgEPsL5QDu4IdBbjLWtqLKSlk1QbYYOgMN+gQmwcSPnq+FfjDKFvvlaBp8KC7OGR5hLUm7o2aB96rMdSiPaHneYXpHHQO/4mj9pO9ydT8pomZ5/K2Cmdqaz9KY9TWst/HES87/15/QdUa1diyrDBsbbooqEllozh/3dttREG979QAC4qgBfGI1ivNx3hBzJVMV5PM78/yYQ1YgyDNBcljkp76qUeo29xeGn6fkbv9UAH4wHthBlB7Yqq50bhhf1+2MsCoYEHrIfQcDucWX+5tLLucmBfiF6oGaV9dMOYteGm7Y5I6gaTEFeOSAJwjkGTZGpc7b+f1Z98liJMKpv/tzcAP/OTVDdPAsCvsFEVH9n+pjWvR4OcZsbpAkQxg8DCcd5ug+4xFW87H/OLHS8FseJi7xx4r6VeOu2QL97atoMPiD1U8D9XnA==; 5:CvLrUaQzsc8TU6g2Y279h4iAHnarpwTgDySSsFUpJjn7OvAHAnTA5aeN3bOHK3YweZTSvK+JdnRgCbXD7zWYmUIOGmuUOsbHf8rOi1YyL1+oVpD3gedJu3EgVa/3ZoYUreeonYpDKUH0PtVE9DI6Mw==; 24:zuZqXkjD5Nq8b6yrwAilAMvn7+9UV5wIxXV7GBxL48Gy9tlAwIPxXFPaPnoCXVSxv49fHE/YtwRASpFXG4MvRwaBeeCaOJqml66AxAJ5KQc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1027; 7:h68wW+Xdgm9GKPaqCUt2bhTiJ1DZY6kYvnmJyMyxDpqwwKqzGL4wONuuWBfNJQ3OtHG1Hun5GV3Wu/aS1c6vX/cANFoz631i/6R4Fu0x01sdBHAE3+jQWwo+oT4FoHS77dvc5SsnccIa6+rkgzGuR3t31OKVjWmI7i65+75v27TDyOYFhN7WrSIFhxNh3EygeACTgcvA8xWr70rPpUuEUFz08CXnWMzAbufjsOn1c1wX/+u5nOfS+7AjthHbKwPnuU6oSOT1AcwYe7JmDUbmEutJFhz8ZyMUjXp6nLeOQMF0XRDbmKP2MmuVgVve/KwxyKkHW+0J4TdPrBE9hottIw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2017 15:27:21.7637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1027 Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 15:27:25 -0000 Hey Thomas, On 07.04.2017 16:47, Thomas Monjalon wrote: >> What if we add to the max_rx_pkt_len description: "the effective maximum >> RX frame size depends on PMD, please refer the PMD guide for the details"? > > I think the problem is not in the documentation but in the implementations > which should be more consistent. The hardware is different, there is not much we can do about it. Nevertheless, we can fix the false comment and have a default for the jumbos, which is beneficial for the apps/examples. > If I understand well, the inconsistency between drivers was already an > issue before your patch. > Your patch fixes an inconsistency in ethdev without fixing the drivers. > We need to know if it is a good first step and if the drivers can be > fixed later. Thomas, some of the examples use a hard-coded jumbo frame size, which is too big for the underlaying PMDs, so those examples fail. The plan was to fix them all with this commit in ethdev but I am not sure now you are to accept the change. It is important for us to have those examples working in the upcoming release, do you think it is better to send fixes for those examples instead of this commit then? Andriy