From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5BF2A052A; Fri, 10 Jul 2020 17:39:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 862CF1DABC; Fri, 10 Jul 2020 17:39:42 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0A32E1DAAA for ; Fri, 10 Jul 2020 17:39:40 +0200 (CEST) IronPort-SDR: 7RRAjZiJPQtWh0cMovsqBQwlg/e25fmb3rYVEBNPTzIq54xwP9Ya7Vnr9/nDyHB5VpJZhXie9h kP6k/xYtkt2A== X-IronPort-AV: E=McAfee;i="6000,8403,9678"; a="209753049" X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="209753049" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 08:39:39 -0700 IronPort-SDR: 0SRRasB6u9BoJUJdGFIHwudCPu7FvCIj7TTWSiklvOpvW6JWj4/nGdFbQQ2B7rgbcnZbWGd5aT RsK0akrkYESQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,336,1589266800"; d="scan'208";a="484213349" Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by fmsmga006.fm.intel.com with ESMTP; 10 Jul 2020 08:39:37 -0700 Received: from irsmsx606.ger.corp.intel.com (163.33.146.139) by irsmsx601.ger.corp.intel.com (163.33.146.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 10 Jul 2020 16:39:36 +0100 Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by IRSMSX606.ger.corp.intel.com ([163.33.146.139]) with mapi id 15.01.1713.004; Fri, 10 Jul 2020 16:39:36 +0100 From: "Yigit, Ferruh" To: Stephen Hemminger CC: "i.dyukov@samsung.com" , "dev@dpdk.org" , "v.kuramshin@samsung.com" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "arybchenko@solarflare.com" , "Zhao1, Wei" , "Guo, Jia" , "Xing, Beilei" , "Yang, Qiming" , "Lu, Wenzhuo" , "mb@smartsharesystems.com" , "Chautru, Nicolas" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Dumitrescu, Cristian" , "Nicolau, Radu" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "skori@marvell.com" , "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "Hunt, David" , "Burakov, Anatoly" , "Li, Xiaoyun" , "Wu, Jingjing" , "Mcnamara, John" , "Singh, Jasvinder" , "Marohn, Byron" , "Wang, Yipeng1" Thread-Topic: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation Thread-Index: AQHWVs3zhxTBIWOlfUqAdriWvYoknqkA8u9Q Date: Fri, 10 Jul 2020 15:39:36 +0000 Message-ID: <40c233d73b2448a1b13e89780bfc9d6d@intel.com> References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200710070226.6045-1-i.dyukov@samsung.com> <20200710070226.6045-3-i.dyukov@samsung.com> <20200710082216.19edf2c4@hermes.lan> In-Reply-To: <20200710082216.19edf2c4@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Fri, 10 Jul 2020 13:06:02 +0000 > "Yigit, Ferruh" wrote: >=20 > > > + /* ignore unknown specifier */ > > > + default: > > > + *str_cur =3D '%'; > > > + offset++; > > > + fmt_cur--; > > > + break; > > > > What do you think ignoring the unknown specifiers and keep continue > > processing the string, instead of break? Just keep unknown specifier > > as it is in the output string. >=20 > My comment was that the function should behave the same as > snprintf() does when handed unknown specifier. What snprintf does is > duplicate the string in the output buffer (like any other non format > character). +1