From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F25FA42C31; Mon, 5 Jun 2023 08:19:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EEEC40A7F; Mon, 5 Jun 2023 08:19:42 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 0106C4003C for ; Mon, 5 Jun 2023 08:19:39 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QZNcX3Blhz18Lsy; Mon, 5 Jun 2023 14:14:52 +0800 (CST) Received: from [10.67.103.42] (10.67.103.42) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 14:19:36 +0800 Message-ID: <40c869f6-5575-d705-6dd0-511672d431fe@huawei.com> Date: Mon, 5 Jun 2023 14:19:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 00/10] support telemetry query ethdev info To: Ferruh Yigit CC: , References: <20230530090510.56812-1-haijie1@huawei.com> From: Jie Hai In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.42] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/6/1 22:36, Ferruh Yigit wrote: > On 5/30/2023 10:05 AM, Jie Hai wrote: >> This patchset supports querying information about ethdev. >> The information includes MAC addresses, RxTx offload, flow ctrl, >> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. >> >> >> Dengdui Huang (1): >> ethdev: support telemetry query MAC addresses >> >> Jie Hai (9): >> ethdev: support RxTx offload display >> ethdev: support telemetry query flow ctrl info >> ethdev: support telemetry query Rx queue info >> ethdev: support telemetry query Tx queue info >> ethdev: add firmware version in telemetry info command >> ethdev: support telemetry query DCB info >> ethdev: support telemetry query RSS info >> ethdev: support telemetry query FEC info >> ethdev: support telemetry query VLAN info >> > > Hi Jie, > > Overall it is good to add more telemetry support, but it is making > 'rte_ethdev.c' bigger, specially naming of the static functions that > telemetry handlers use making file confusing. > Can you please create a specific file for telemetry functions? > > First you can move the existing ones and later add your patches. > > Also there is a common part that reads and verifies port_id, I think > that part can be extracted to a common function, I will comment on it in > one of the patches. > > Thanks, > ferruh > . Hi ferruh, Thanks for your review, I will fix them in the next version. Thanks, Jie Hai