From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BE477FB92 for ; Tue, 20 Dec 2016 15:20:23 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 20 Dec 2016 06:20:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="44625757" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2016 06:20:21 -0800 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org References: <1481997835-23288-1-git-send-email-3chas3@gmail.com> Cc: "John W. Linville" From: Ferruh Yigit Message-ID: <40da3bb6-9d84-9703-36f7-a0eb21fc48dc@intel.com> Date: Tue, 20 Dec 2016 14:20:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481997835-23288-1-git-send-email-3chas3@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 14:20:24 -0000 On 12/17/2016 6:03 PM, Chas Williams wrote: > This patch initializes the eth_dev->link_intr_cbs queue which is > used when af_packet is passed into rte_eth_ev_callback_register(). Why do you want to register callback to af_packet PMD, it won't be calling them? > > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") > > Signed-off-by: Chas Williams <3chas3@gmail.com> Please cc the maintainers... CC: John W. Linville > --- > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index a1e13ff..ea5070a 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name, > (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name; > (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > (*eth_dev)->data->numa_node = numa_node; > + TAILQ_INIT(&((*eth_dev)->link_intr_cbs)); > > return 0; > >