From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 3B1D0C6CA for ; Thu, 30 Jul 2015 20:23:16 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so31189329wic.0 for ; Thu, 30 Jul 2015 11:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=R0j6qlGW0lpJ6aQDegtTHhoe0bUhtYqq8WVNYpAFnbU=; b=Xi5WkznEV0bxz0mnGvyDup8prHfJZ24r2zDJGDYxGz6wQbaI4wpASW9dP/Zn5Pfcug mPYbDGkmBUKknMSzsaNYXRC4Bv5kX2fsitawN/lLZBqIqFH9sCC55JthKMPxhuQ+TjA7 IhrwdwY7WXuKHKVITdADDowH87o6bXke0589OInQ9hwmINiqIVbLOc5TZuwfdtN3WUTX 5ZEec7wr1RS5GNtl3HE7f4Uqyi1Re290ievMvVcAgt6sHM+TzHjWhLmxlanMmKs1p+zO bHjG02OjmTTp5WKqofss2/8pQqat0qIBguOtyIkkkNOgRrH3IQE9Q/jCGrC8/mPvnKZH navw== X-Gm-Message-State: ALoCoQmTlGwH3YbZ1uqIPrJnCvDvVgGsU3I/mhkP3NriICrGKJOayGdkn7CGNbTpY7NzBzaQum+z X-Received: by 10.180.216.42 with SMTP id on10mr9200831wic.3.1438280596146; Thu, 30 Jul 2015 11:23:16 -0700 (PDT) Received: from xps13.localnet (236.202.154.77.rev.sfr.net. [77.154.202.236]) by smtp.gmail.com with ESMTPSA id k4sm369834wix.19.2015.07.30.11.23.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 11:23:15 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 30 Jul 2015 19:31:20 +0200 Message-ID: <4101976.0ECuOVF5zn@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436482868-7400-4-git-send-email-stephen@networkplumber.org> References: <1436482868-7400-1-git-send-email-stephen@networkplumber.org> <1436482868-7400-4-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v3 3/6] ixgbe: allow pruning log during build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 18:23:16 -0000 2015-07-09 16:01, Stephen Hemminger: > From: Stephen Hemminger > > The ixgbe driver was not following DPDK convention and > was leaving loggin always in even if LOG_LEVEL was configured > to disable debug logs. > > Signed-off-by: Stephen Hemminger This series is fixing e1000 and ixgbe. There is the same issue with i40e, fm10k and bnx2x. I will fix them in the same way. For consistency, examples/l3fwd-power and eal_common_tailqs.c should use RTE_LOG instead of rte_log.