DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
	Luca Boccassi <bluca@debian.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] Backporting rte_intr_ack
Date: Fri, 22 Nov 2019 16:24:16 +0100	[thread overview]
Message-ID: <4111590.xNL0bnPyNO@xps> (raw)
In-Reply-To: <b4a28d70-2fed-3678-d15e-2fbb78b7f51a@redhat.com>

22/11/2019 16:12, Kevin Traynor:
> On 19/11/2019 10:40, Thomas Monjalon wrote:
> > 14/10/2019 17:55, David Marchand:
> >> The api rte_intr_ack that has been introduced to fix a race condition
> >> observed with (at least) qede drivers/hw.
> >> This is an experimental api in master but it still fixes a problem, so
> >> I'd like to see this in stable branches.
> > 
> > This is more a driver interface than an API.
> > 
> >> Opinions?
> > 
> > If it comes with a fix in a driver, I think it is worth backporting.
> > 
> > 
> 
> I think fine to backport as it solves an observed problem for qede.
> However, a bit reluctant to update all the drivers to use it without
> acks from their maintainers.
> 
> Discussed with David offline and idea to backport and only update qede
> now. Other drivers can be updated if there is a request from
> maintainers. How does it sound?

It's better than nothing.
But it makes tracking of backports more difficult.
Is it a common practice to backport half of fixes?



  reply	other threads:[~2019-11-22 15:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 15:55 David Marchand
2019-11-19 10:40 ` Thomas Monjalon
2019-11-22 15:12   ` Kevin Traynor
2019-11-22 15:24     ` Thomas Monjalon [this message]
2019-11-22 16:33       ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4111590.xNL0bnPyNO@xps \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).